From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 976EDC3F6B0 for ; Mon, 8 Aug 2022 08:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242072AbiHHIFo (ORCPT ); Mon, 8 Aug 2022 04:05:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242062AbiHHIFh (ORCPT ); Mon, 8 Aug 2022 04:05:37 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37822D10B for ; Mon, 8 Aug 2022 01:05:31 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id 13so6435735plo.12 for ; Mon, 08 Aug 2022 01:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=O+SVGz/QwwQDImSPbxMLknJVY6/6roIp/5evt7khqi8=; b=TVmki4I1dSb+1aSt1UwuAmwywPp5Ykpxef49+Z58uTNcDh8SGKkS9NuaKfCpkNQcDO 0tjc/PD0zoncnQ47Jw/ZZ5EiC+1o/ngsmXCZkFoMpDlUu9vs0UBSQdH2xtSn0CpPJfMw jA4cTlIU+7xx7PB0Q9QLrJP+fiB6IIHkBNwiO05czQmuFbVquBEAu8MIVFeBGNvdEqfP FLPihOKNSZpCyWseKw9wa4vwhHg+NAwf7KjuSC2xJmCbxX4c5+Y2ozps/QCvwnqB4ULE 6TMWUGzT4Obt/kknCXCQLMf0rs0AM0Qsven6S6lvmv/CEE7CcIAU/O/V3cPCBs3wwPeV Ljrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=O+SVGz/QwwQDImSPbxMLknJVY6/6roIp/5evt7khqi8=; b=NKyMovJ7/XMhOXOlcVKLsHgu6RG1Zouxx6/JmkIIiL7Bpvwi5M02+ZLhyNTPriJu7U 0PS/RMt68IovoSdHuTaf6PkOMbCwB9Kl3WP7zkTs+hV/lwzuFMJWrlpnTgbMbBpu3x6j 1A7ux8CNyOLmLU0I0UR8DwWysdKOU8WbkxvnX18nZGZiruAd8KWusNnhHDDKQ5xWg9Er y6Zhxrvfpl/GcFomAljJzvbZu1+e76LvFCLjJRv0y5UoJxkN0VetwFwi/1VZkRi/3z/X PYoSqIxOIMwHrKUjpWG8/3Z3aczuQkyABZLFJOpCm+gvskxllRiNeCvXn8yONghTFi9m ABIg== X-Gm-Message-State: ACgBeo38CI2NrFuGGVwj7Bdq88RVHljqgaWm3EjObOgFg3dowUhdEdx4 7NbjXuRILrAbypraMdHcuhcx X-Google-Smtp-Source: AA6agR6PMY+p1aipPNjyAQdBqThMo10eyPly8Z14382u1rTR3VO8S+wL5KHwN9bEEiP3taFf2dKwOg== X-Received: by 2002:a17:902:aa89:b0:16b:e514:54d2 with SMTP id d9-20020a170902aa8900b0016be51454d2mr17993521plr.127.1659945930573; Mon, 08 Aug 2022 01:05:30 -0700 (PDT) Received: from thinkpad ([117.193.212.254]) by smtp.gmail.com with ESMTPSA id l21-20020a17090a599500b001f4d4a1b494sm7516034pji.7.2022.08.08.01.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 01:05:30 -0700 (PDT) Date: Mon, 8 Aug 2022 13:35:22 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Johan Hovold , Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krishna Kurapati , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Pavankumar Kondeti , quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 7/9] dt-bindings: usb: qcom,dwc3: add wakeup-source property Message-ID: <20220808080522.GB7601@thinkpad> References: <20220804151001.23612-1-johan+linaro@kernel.org> <20220804151001.23612-8-johan+linaro@kernel.org> <20220806150848.GH14384@thinkpad> <20220806165238.GM14384@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Aug 06, 2022 at 07:09:44PM +0200, Johan Hovold wrote: > On Sat, Aug 06, 2022 at 10:22:38PM +0530, Manivannan Sadhasivam wrote: > > On Sat, Aug 06, 2022 at 06:41:37PM +0200, Johan Hovold wrote: > > > On Sat, Aug 06, 2022 at 08:38:48PM +0530, Manivannan Sadhasivam wrote: > > > > On Thu, Aug 04, 2022 at 05:09:59PM +0200, Johan Hovold wrote: > > > > > Add a wakeup-source property to the binding to describe whether the > > > > > wakeup interrupts can wake the system from suspend. > > > > > > > > > > Acked-by: Rob Herring > > > > > Signed-off-by: Johan Hovold > > > > > > > > So this is based on the fact that Qcom glue wrapper is supplying the wakeup > > > > interrupts. But isn't it possible that on other platform, the DWC IP can supply > > > > wakeup interrupts? > > > > > > Yeah, possibly, and that's why Rob suggested keeping the 'wakeup-source' > > > property also in the core node. > > > > > > > In the driver, the wakeup-source parsing has been moved to the Qcom glue driver. > > > > But this contradicts with the binding. > > > > > > That's irrelevant. The core driver does not implement wakeup support. It > > > was just added as a hack for the Qualcomm driver, and you won't get > > > wakeup-capability for other platforms by just parsing the property in > > > the core driver. > > > > > > When/if wakeup support for such a platform is added, then the core > > > driver may need to look at the property again. > > > > > > > My point is, the platform drivers are free to add "wakeup-source" property in > > the DWC node. Then in that case, the DWC driver should handle the capability, > > isn't it? > > No, not really. They wouldn't violate the current binding, but it would > arguably still be wrong to do so unless that platform actually supports > wakeup without involvement from a glue layer. > > Perhaps we should reconsider reverting the binding update adding this > property to the core node and only add it selectively for the platforms > for which is actually applies (if they even exist). > That sounds right to me. > > I know it is broken currently, but moving the wakeup parsing code is not > > helping either. > > It's not even broken. It has never even been implemented. > > Just because someone added a hack that should probably never have been > merged in the first place, doesn't mean we should somehow pretend that > we support it. > > > And... I'm aware of the fact that the binding should describe the hardware and > > not the limitation of the driver. So perhaps we should document it in the > > driver as a TODO or something? > > I'd rather just revert the binding update to avoid having discussions > like this. We don't even know if it's possible to support on any > platform yet (and remember that none of this has even been in an rc > release yet). > Okay. Thanks, Mani > Johan -- மணிவண்ணன் சதாசிவம்