From: Li Zhong <floridsleeves@gmail.com>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: heghedus.razvan@gmail.com, evgreen@chromium.org,
yuanjilin@cdjrlc.com, stern@rowland.harvard.edu,
jj251510319013@gmail.com, gregkh@linuxfoundation.org,
Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v1] drivers/usb/core/driver: check return value of usb_set_interface()
Date: Thu, 8 Sep 2022 21:42:14 -0700 [thread overview]
Message-ID: <20220909044215.2620024-1-floridsleeves@gmail.com> (raw)
Check return value of usb_set_interface() and report error if it fails.
Otherwise usb_set_interface() may fail without any warnings.
This flaw was found using an experimental static analysis tool we are
developing. Report warnings when the function usb_set_interface() fails
can increase the dianosability.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/usb/core/driver.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 7e7e119c253f..ee375b5eafe6 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -1332,8 +1332,10 @@ static int usb_resume_interface(struct usb_device *udev,
/* Carry out a deferred switch to altsetting 0 */
if (intf->needs_altsetting0 && !intf->dev.power.is_prepared) {
- usb_set_interface(udev, intf->altsetting[0].
- desc.bInterfaceNumber, 0);
+ status = usb_set_interface(udev, intf->altsetting[0].desc.bInterfaceNumber, 0);
+ if (status < 0)
+ dev_err(intf->dev, "usb_set_interface error %d\n",
+ status);
intf->needs_altsetting0 = 0;
}
goto done;
--
2.25.1
next reply other threads:[~2022-09-09 4:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 4:42 Li Zhong [this message]
2022-09-09 5:27 ` [PATCH v1] drivers/usb/core/driver: check return value of usb_set_interface() Greg KH
2022-09-09 10:12 ` kernel test robot
2022-09-09 10:21 ` Greg KH
2022-09-09 11:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909044215.2620024-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heghedus.razvan@gmail.com \
--cc=jj251510319013@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox