Re: [PATCH] usb: gadget: uvc: default the ctrl request interface offsets

[Michael Grzeschik <mgr@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On Mon, Oct 10, 2022 at 10:21:35PM +0200, Greg KH wrote:
>On Mon, Oct 10, 2022 at 08:20:28PM +0200, Michael Grzeschik wrote:
>> For the userspace it is needed to distinguish between requests for the
>> control or streaming interface. The userspace would have to parse the
>> configfs to know which interface index it has to compare the ctrl
>> requests against. Since the interface numbers are not fixed, e.g. for
>> composite gadgets, the interface offset depends on the setup.
>>
>> The kernel has this information when handing over the ctrl request to
>> the userspace. This patch removes the offset from the interface numbers
>> and expose the default interface defines in the uapi g_uvc.h.
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> ---
>>  drivers/usb/gadget/function/f_uvc.c | 16 +++++++++++++---
>>  include/uapi/linux/usb/g_uvc.h      |  3 +++
>>  2 files changed, 16 insertions(+), 3 deletions(-)
>
>This is a v2, what changed from v1?

v1 - v2: - removed the extra variable in struct uvc_event
         - replacing the ctrl request bits in place
	 - included the move of the defualt interface defines to g_uvc.h

Thanks,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]