Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

Guenter Roeck
2022-11-05T19:31:40Z

On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote:
>
> Back in April, I posted an RFC patch set to help mitigate a common issue
> where a timer gets armed just before it is freed, and when the timer
> goes off, it crashes in the timer code without any evidence of who the
> culprit was. I got side tracked and never finished up on that patch set.
> Since this type of crash is still our #1 crash we are seeing in the field,
> it has become a priority again to finish it.
>
> The last version of that patch set is here:
>
> https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/
>
> I'm calling this version 4a as it only has obvious changes were the timer that
> is being shutdown is in the same function where it will be freed or released,
> as this series should be "safe" for adding. I'll be calling the other patches
> 4b for the next merge window.
>

For the series, as far as my testbed goes:

Build results:
total: 152 pass: 152 fail: 0
Qemu test results:
total: 500 pass: 500 fail: 0

No runtime crashes or warnings observed.

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter