From: Jakub Kicinski <kuba@kernel.org>
To: Albert Zhou <albert.zhou.50@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
nic_swsd@realtek.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next RFC 0/5] Update r8152 to version two
Date: Tue, 8 Nov 2022 12:50:28 -0800 [thread overview]
Message-ID: <20221108125028.35a765be@kernel.org> (raw)
In-Reply-To: <20221108153342.18979-1-albert.zhou.50@gmail.com>
On Wed, 9 Nov 2022 02:33:37 +1100 Albert Zhou wrote:
> This patch integrates the version-two r8152 drivers from Realtek into
> the kernel. I am new to kernel development, so apologies if I make
> newbie mistakes.
>
> I have tested the updated module in v6.1 on my machine, without any
> issues.
What are you trying to achieve? Copy pasting 18k LoC into the kernel
in a single patch is definitely not the way we do development. If there
are features missing in the upstream driver, or you see discrepancies
in the operation - please prepare targeted patches.
next prev parent reply other threads:[~2022-11-08 20:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 15:33 [PATCH net-next RFC 0/5] Update r8152 to version two Albert Zhou
2022-11-08 15:33 ` [PATCH net-next RFC 1/5] net: move back netif_set_gso_max helpers Albert Zhou
2022-11-08 17:27 ` Greg KH
2022-11-08 15:33 ` [PATCH net-next RFC 3/5] r8152: remove backwards compatibility Albert Zhou
2022-11-08 15:33 ` [PATCH net-next RFC 4/5] r8152: merge header into source Albert Zhou
2022-11-08 15:33 ` [PATCH net-next RFC 5/5] r8152: remove redundant code Albert Zhou
[not found] ` <20221108153342.18979-3-albert.zhou.50@gmail.com>
2022-11-08 17:28 ` [PATCH net-next RFC 2/5] r8152: update to version two Greg KH
2022-11-09 4:50 ` Albert Zhou
2022-11-09 7:42 ` Greg KH
2022-11-08 20:50 ` Jakub Kicinski [this message]
2022-11-09 4:43 ` [PATCH net-next RFC 0/5] Update r8152 " Albert Zhou
2022-11-09 18:40 ` Jakub Kicinski
2022-11-16 15:13 ` Albert Zhou
2022-11-16 16:34 ` Jakub Kicinski
2022-11-08 21:03 ` Francois Romieu
2022-11-09 4:54 ` Albert Zhou
2022-11-09 11:02 ` Hayes Wang
2022-11-09 11:20 ` Albert Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108125028.35a765be@kernel.org \
--to=kuba@kernel.org \
--cc=albert.zhou.50@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).