From: Davide Tronchin <davide.tronchin.94@gmail.com>
To: larsm17@gmail.com
Cc: cesare.marzano@gmail.com, davide.tronchin.94@gmail.com,
gregkh@linuxfoundation.org, johan@kernel.org,
linux-usb@vger.kernel.org, marco.demarco@posteo.net
Subject: [PATCH v5 3/3] USB: serial: option: add u-blox LARA-L6 modem
Date: Wed, 9 Nov 2022 17:17:13 +0100 [thread overview]
Message-ID: <20221109161713.31723-3-davide.tronchin.94@gmail.com> (raw)
In-Reply-To: <20221109161713.31723-1-davide.tronchin.94@gmail.com>
Add LARA-L6 PIDs for three different USB compositions.
LARA-L6 module can be configured (by AT interface) in three different
USB modes:
* Default mode (Vendor ID: 0x1546 Product ID: 0x1341) with 4 serial
interfaces
* RmNet mode (Vendor ID: 0x1546 Product ID: 0x1342) with 4 serial
interfaces and 1 RmNet virtual network interface
* CDC-ECM mode (Vendor ID: 0x1546 Product ID: 0x1343) with 4 serial
interface and 1 CDC-ECM virtual network interface
In default mode LARA-L6 exposes the following interfaces:
If 0: Diagnostic
If 1: AT parser
If 2: AT parser
If 3: AT parser/alternative functions
In RmNet mode LARA-L6 exposes the following interfaces:
If 0: Diagnostic
If 1: AT parser
If 2: AT parser
If 3: AT parset/alternative functions
If 4: RMNET interface
In CDC-ECM mode LARA-L6 exposes the following interfaces:
If 0: Diagnostic
If 1: AT parser
If 2: AT parser
If 3: AT parset/alternative functions
If 4: CDC-ECM interface
Signed-off-by: Davide Tronchin <davide.tronchin.94@gmail.com>
---
V4 -> V5: kept PID 0x90fa to maintain the support for other products
which use VID:PID 0x05c6:0x90fa. Remove interface 4 from blacklist
for LARA-L6 default mode since it is not needed.
V3 -> V4: as requested, the patch has been split to 3 sub-patches.
Fix comment format.
V2 -> V3: added this section to tracking changes with previous versions.
Added some explanations about the RSVD(4) in the description session.
Added reservation to port 4 of VID:PID 0x05C6:0x908B to meet other
companies QMI net interface implementation.
V1 -> V2: define UBLOX_PRODUCT_LARA_R6 0x908b has been deleted together
with the previosly provided definition of USB_DEVICE since the PID
is used by another vendor.
The LARA-L6 patch part is the same of the previosly provided one.
drivers/usb/serial/option.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 011b9a3b7571..f892a3c80cf1 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -580,6 +580,11 @@ static void option_instat_callback(struct urb *urb);
#define OPPO_VENDOR_ID 0x22d9
#define OPPO_PRODUCT_R11 0x276c
+/* These u-blox products use u-blox's vendor ID */
+#define UBLOX_VENDOR_ID 0x1546
+#define UBLOX_PRODUCT_LARA_L6 0x1341
+#define UBLOX_PRODUCT_LARA_L6_RMNET 0x1342
+#define UBLOX_PRODUCT_LARA_L6_ECM 0x1343
/* Device flags */
@@ -1127,6 +1132,12 @@ static const struct usb_device_id option_ids[] = {
.driver_info = RSVD(3) },
{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x908b), /* u-blox LARA-R6 00B */
.driver_info = RSVD(4) },
+ /* u-blox products using u-blox vendor ID */
+ { USB_DEVICE(UBLOX_VENDOR_ID, UBLOX_PRODUCT_LARA_L6) },
+ { USB_DEVICE(UBLOX_VENDOR_ID, UBLOX_PRODUCT_LARA_L6_RMNET),
+ .driver_info = RSVD(4) },
+ { USB_DEVICE(UBLOX_VENDOR_ID, UBLOX_PRODUCT_LARA_L6_ECM),
+ .driver_info = RSVD(4) },
/* Quectel products using Quectel vendor ID */
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff),
.driver_info = NUMEP2 },
--
2.34.1
next prev parent reply other threads:[~2022-11-09 16:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 9:27 [PATCH v3] USB: serial: option: the patch is meant to support LARA-R6 Cat 1 and LARA-L6 CAT 4 module family Davide Tronchin
2022-10-27 14:11 ` Johan Hovold
2022-11-08 16:29 ` [PATCH v4 1/3] USB: serial: option: remove old LARA-R6 PID Davide Tronchin
2022-11-08 16:30 ` [PATCH v4 2/3] USB: serial: option: add u-blox LARA-R6 00B modem Davide Tronchin
2022-11-08 16:30 ` [PATCH v4 3/3] USB: serial: option: add u-blox LARA-L6 modem Davide Tronchin
2022-11-09 4:10 ` Lars Melin
2022-11-15 10:18 ` Johan Hovold
2022-11-15 10:22 ` Johan Hovold
2022-11-15 16:50 ` Davide Tronchin
2022-11-16 8:10 ` Johan Hovold
2022-11-09 4:15 ` [PATCH v4 1/3] USB: serial: option: remove old LARA-R6 PID Lars Melin
2022-11-09 9:34 ` Lars Melin
2022-11-09 16:17 ` [PATCH v5 " Davide Tronchin
2022-11-09 16:17 ` [PATCH v5 2/3] USB: serial: option: add u-blox LARA-R6 00B modem Davide Tronchin
2022-11-09 16:17 ` Davide Tronchin [this message]
2022-11-15 10:12 ` [PATCH v5 1/3] USB: serial: option: remove old LARA-R6 PID Johan Hovold
2022-11-15 16:46 ` Davide Tronchin
2022-11-16 8:05 ` Johan Hovold
2022-11-16 9:50 ` Davide Tronchin
2022-11-16 9:55 ` Johan Hovold
2022-11-16 15:59 ` [PATCH v6 " Davide Tronchin
2022-11-16 15:59 ` [PATCH v6 2/3] USB: serial: option: add u-blox LARA-R6 00B modem Davide Tronchin
2022-11-16 15:59 ` [PATCH v6 3/3] USB: serial: option: add u-blox LARA-L6 modem Davide Tronchin
2022-11-16 16:28 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109161713.31723-3-davide.tronchin.94@gmail.com \
--to=davide.tronchin.94@gmail.com \
--cc=cesare.marzano@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=marco.demarco@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).