From: Jakub Kicinski <kuba@kernel.org>
To: Albert Zhou <albert.zhou.50@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
nic_swsd@realtek.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH net-next RFC 0/5] Update r8152 to version two
Date: Wed, 16 Nov 2022 08:34:42 -0800 [thread overview]
Message-ID: <20221116083442.71d9b32b@kernel.org> (raw)
In-Reply-To: <d43ad04e-8c24-d17c-ef09-984924ad1c4c@gmail.com>
On Thu, 17 Nov 2022 02:13:49 +1100 Albert Zhou wrote:
> After a lot of testing, I have come to the conclusion that the reason
> for the speed difference between the v1 and v2 driver is actually the
> firmware.
>
> The v2 driver doesn't even #include <linux/firmware.h>; so it doesn't
> load the standard firmware in /lib/firmware/rtl_nic. It seems the
> firmware is actually written in the source and loaded directly.
>
> Since firmware is not even part of the kernel, it's probably
> inappropriate to submit a patch that modifies the firmware of a device,
> would that be correct?
>
> If that's the case, it's probably best if Realtek can update the
> firmware on the linux firmware git.
>
> Not sure otherwise how to proceed. Any suggestions?
Getting Realtek to update the FW would definitely be the best avenue.
If that fails you can try to update it yourself, but it's always a bit
tricky because of licensing. You may need to invent your own file
format :S
next prev parent reply other threads:[~2022-11-16 16:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 15:33 [PATCH net-next RFC 0/5] Update r8152 to version two Albert Zhou
2022-11-08 15:33 ` [PATCH net-next RFC 1/5] net: move back netif_set_gso_max helpers Albert Zhou
2022-11-08 17:27 ` Greg KH
2022-11-08 15:33 ` [PATCH net-next RFC 3/5] r8152: remove backwards compatibility Albert Zhou
2022-11-08 15:33 ` [PATCH net-next RFC 4/5] r8152: merge header into source Albert Zhou
2022-11-08 15:33 ` [PATCH net-next RFC 5/5] r8152: remove redundant code Albert Zhou
[not found] ` <20221108153342.18979-3-albert.zhou.50@gmail.com>
2022-11-08 17:28 ` [PATCH net-next RFC 2/5] r8152: update to version two Greg KH
2022-11-09 4:50 ` Albert Zhou
2022-11-09 7:42 ` Greg KH
2022-11-08 20:50 ` [PATCH net-next RFC 0/5] Update r8152 " Jakub Kicinski
2022-11-09 4:43 ` Albert Zhou
2022-11-09 18:40 ` Jakub Kicinski
2022-11-16 15:13 ` Albert Zhou
2022-11-16 16:34 ` Jakub Kicinski [this message]
2022-11-08 21:03 ` Francois Romieu
2022-11-09 4:54 ` Albert Zhou
2022-11-09 11:02 ` Hayes Wang
2022-11-09 11:20 ` Albert Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116083442.71d9b32b@kernel.org \
--to=kuba@kernel.org \
--cc=albert.zhou.50@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).