linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Davide Tronchin <davide.tronchin.94@gmail.com>
To: johan@kernel.org
Cc: cesare.marzano@gmail.com, davide.tronchin.94@gmail.com,
	gregkh@linuxfoundation.org, larsm17@gmail.com,
	linux-usb@vger.kernel.org, marco.demarco@posteo.net
Subject: [PATCH v6 2/3] USB: serial: option: add u-blox LARA-R6 00B modem
Date: Wed, 16 Nov 2022 16:59:49 +0100	[thread overview]
Message-ID: <20221116155950.59609-2-davide.tronchin.94@gmail.com> (raw)
In-Reply-To: <20221116155950.59609-1-davide.tronchin.94@gmail.com>

The official LARA-R6 (00B) modem uses 0x908b PID. LARA-R6 00B does not
implement a QMI interface on port 4, the reservation (RSVD(4)) has been
added to meet other companies that implement QMI on that interface.

LARA-R6 00B USB composition exposes the following interfaces:
If 0: Diagnostic
If 1: AT parser
If 2: AT parser
If 3: AT parser/alternative functions

Signed-off-by: Davide Tronchin <davide.tronchin.94@gmail.com>
---

V5 -> V6: text wrapped correctly.

V4 -> V5: kept PID 0x90fa to maintain the support for other products
which use VID:PID 0x05c6:0x90fa. Remove interface 4 from blacklist
for LARA-L6 default mode since it is not needed.

V3 -> V4: as requested, the patch has been split to 3 sub-patches.
Fix comment format.

V2 -> V3: added this section to tracking changes with previous versions.
Added some explanations about the RSVD(4) in the description session.
Added reservation to port 4 of VID:PID 0x05C6:0x908B to meet other
companies QMI net interface implementation.

V1 -> V2: define UBLOX_PRODUCT_LARA_R6 0x908b has been deleted together
with the previosly provided definition of USB_DEVICE since the PID
is used by another vendor.
The LARA-L6 patch part is the same of the previosly provided one.

 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index b93285b5175b..011b9a3b7571 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1125,6 +1125,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(1) | RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x90fa),
 	  .driver_info = RSVD(3) },
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x908b), /* u-blox LARA-R6 00B */
+	  .driver_info = RSVD(4) },
 	/* Quectel products using Quectel vendor ID */
 	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff),
 	  .driver_info = NUMEP2 },
-- 
2.34.1


  reply	other threads:[~2022-11-16 16:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  9:27 [PATCH v3] USB: serial: option: the patch is meant to support LARA-R6 Cat 1 and LARA-L6 CAT 4 module family Davide Tronchin
2022-10-27 14:11 ` Johan Hovold
2022-11-08 16:29   ` [PATCH v4 1/3] USB: serial: option: remove old LARA-R6 PID Davide Tronchin
2022-11-08 16:30     ` [PATCH v4 2/3] USB: serial: option: add u-blox LARA-R6 00B modem Davide Tronchin
2022-11-08 16:30     ` [PATCH v4 3/3] USB: serial: option: add u-blox LARA-L6 modem Davide Tronchin
2022-11-09  4:10       ` Lars Melin
2022-11-15 10:18       ` Johan Hovold
2022-11-15 10:22         ` Johan Hovold
2022-11-15 16:50           ` Davide Tronchin
2022-11-16  8:10             ` Johan Hovold
2022-11-09  4:15     ` [PATCH v4 1/3] USB: serial: option: remove old LARA-R6 PID Lars Melin
2022-11-09  9:34     ` Lars Melin
2022-11-09 16:17       ` [PATCH v5 " Davide Tronchin
2022-11-09 16:17         ` [PATCH v5 2/3] USB: serial: option: add u-blox LARA-R6 00B modem Davide Tronchin
2022-11-09 16:17         ` [PATCH v5 3/3] USB: serial: option: add u-blox LARA-L6 modem Davide Tronchin
2022-11-15 10:12         ` [PATCH v5 1/3] USB: serial: option: remove old LARA-R6 PID Johan Hovold
2022-11-15 16:46           ` Davide Tronchin
2022-11-16  8:05             ` Johan Hovold
2022-11-16  9:50               ` Davide Tronchin
2022-11-16  9:55                 ` Johan Hovold
2022-11-16 15:59                   ` [PATCH v6 " Davide Tronchin
2022-11-16 15:59                     ` Davide Tronchin [this message]
2022-11-16 15:59                     ` [PATCH v6 3/3] USB: serial: option: add u-blox LARA-L6 modem Davide Tronchin
2022-11-16 16:28                       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116155950.59609-2-davide.tronchin.94@gmail.com \
    --to=davide.tronchin.94@gmail.com \
    --cc=cesare.marzano@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=marco.demarco@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).