From: Szymon Heidrich <szymon.heidrich@gmail.com>
To: dan.scally@ideasonboard.com, laurent.pinchart@ideasonboard.com
Cc: szymon.heidrich@gmail.com, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] usb: gadget: uvc: Prevent buffer overflow in setup handler
Date: Thu, 1 Dec 2022 20:11:34 +0100 [thread overview]
Message-ID: <20221201191134.12404-1-szymon.heidrich@gmail.com> (raw)
In-Reply-To: <Y4jqVZfEj+/VdfnH@kroah.com>
Setup function uvc_function_setup permits control transfer
requests with up to 64 bytes of payload (UVC_MAX_REQUEST_SIZE),
data stage handler for OUT transfer uses memcpy to copy req->actual
bytes to uvc_event->data.data array of size 60. This may result
in an overflow of 4 bytes.
Signed-off-by: Szymon Heidrich <szymon.heidrich@gmail.com>
---
V1 -> V2: Corrected commit message and changed ?: in favor of min_t
drivers/usb/gadget/function/f_uvc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
index 6e196e061..4419b7972 100644
--- a/drivers/usb/gadget/function/f_uvc.c
+++ b/drivers/usb/gadget/function/f_uvc.c
@@ -216,8 +216,9 @@ uvc_function_ep0_complete(struct usb_ep *ep, struct usb_request *req)
memset(&v4l2_event, 0, sizeof(v4l2_event));
v4l2_event.type = UVC_EVENT_DATA;
- uvc_event->data.length = req->actual;
- memcpy(&uvc_event->data.data, req->buf, req->actual);
+ uvc_event->data.length = min_t(unsigned int, req->actual,
+ sizeof(uvc_event->data.data));
+ memcpy(&uvc_event->data.data, req->buf, uvc_event->data.length);
v4l2_event_queue(&uvc->vdev, &v4l2_event);
}
}
--
2.38.1
next prev parent reply other threads:[~2022-12-01 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 12:21 [PATCH] Prevent buffer overflow in UVC Gadget setup handler Szymon Heidrich
2022-12-01 12:28 ` Greg Kroah-Hartman
2022-12-01 12:44 ` Szymon Heidrich
2022-12-01 13:49 ` Dan Scally
2022-12-01 14:22 ` Szymon Heidrich
2022-12-01 15:45 ` [PATCH v2] usb: gadget: uvc: Prevent buffer overflow in " Szymon Heidrich
2022-12-01 17:54 ` Greg Kroah-Hartman
2022-12-01 19:11 ` Szymon Heidrich [this message]
2022-12-06 11:33 ` Dan Scally
2022-12-06 14:13 ` [PATCH v3] " Szymon Heidrich
2022-12-06 21:21 ` Laurent Pinchart
2022-12-06 21:43 ` Szymon Heidrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201191134.12404-1-szymon.heidrich@gmail.com \
--to=szymon.heidrich@gmail.com \
--cc=balbi@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox