Re: [PATCH 1/3] usb: gadget: uvc: Rename uvc_control_ep

Dan Scally
2022-12-08T15:40:11Z

Hi Greg

On 08/12/2022 15:33, Greg KH wrote:
> On Mon, Dec 05, 2022 at 02:37:56PM +0000, Daniel Scally wrote:
>> The f_uvc code defines an endpoint named "uvc_control_ep" but it
>> is configured with a non-zero endpoint address and has its
>> bmAttributes flagged as USB_ENDPOINT_XFER_INT - this cannot be the
>> VideoControl interface's control endpoint, as the default endpoint
>> 0 is used for that purpose. This is instead the optional interrupt
>> endpoint that can be contained by a VideoControl interface.
>>
>> Rename the variables to make that clear.
> Does userspace documentation also need to be updated to reflect this
> change?

Not for this one I don't think; the data sent to userspace was already
correct and isn't changing, it's just the internal variable name that
is...but for #2/3 absolutely; I'll update the documentation in a v2.

> thanks,
>
> greg k-h