Re: [PATCH 0/8] can: usb: remove all usb_set_intfdata(intf, NULL) in drivers' disconnect()

Alan Stern
2022-12-08T16:28:55Z

On Fri, Dec 09, 2022 at 12:44:51AM +0900, Vincent MAILHOL wrote:
> On Thu. 8 Dec. 2022 at 20:04, Oliver Neukum <oneukum@suse.com> wrote:

> > >> which is likely, then please also remove checks like this:
> > >>
> > >> struct ems_usb *dev = usb_get_intfdata(intf);
> > >>
> > >> usb_set_intfdata(intf, NULL);
> > >>
> > >> if (dev) {
> >
> > Here. If you have a driver that uses usb_claim_interface().
> > You need this check or you unregister an already unregistered
> > netdev.
>
> Sorry, but with all my best intentions, I still do not get it. During
> the second iteration, inft is NULL and:

No, intf is never NULL. Rather, the driver-specific pointer stored in
intfdata may be NULL.

You seem to be confusing intf with intfdata(intf).

> /* equivalent to dev = intf->dev.data. Because intf is NULL,
> * this is a NULL pointer dereference */
> struct ems_usb *dev = usb_get_intfdata(intf);

So here dev will be NULL when the second interface's disconnect routine
runs, because the first time through the routine sets the intfdata to
NULL for both interfaces:

USB core calls ->disconnect(intf1)

disconnect routine sets intfdata(intf1) and
intfdata(intf2) both to NULL and handles the
disconnection

USB core calls ->disconnect(intf2)

disconnect routine sees that intfdata(intf2) is
already NULL, so it knows that it doesn't need
to do anything more.

As you can see in this scenario, neither intf1 nor intf2 is ever NULL.

> /* OK, intf is already NULL */
> usb_set_intfdata(intf, NULL);
>
> /* follows a NULL pointer dereference so this is undefined
> * behaviour */
> if (dev) {
>
> How is this a valid check that you entered the function for the second
> time? If intf is the flag, you should check intf, not dev? Something
> like this:

intf is not a flag; it is the argument to the function and is never
NULL. The flag is the intfdata.

> struct ems_usb *dev;
>
> if (!intf)
> return;
>
> dev = usb_get_intfdata(intf);
> /* ... */
>
> I just can not see the connection between intf being NULL and the if
> (dev) check. All I see is some undefined behaviour, sorry.

Once you get it straightened out in your head, you will understand.

Alan Stern