From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973C1C61DA4 for ; Thu, 9 Mar 2023 17:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbjCIRTV (ORCPT ); Thu, 9 Mar 2023 12:19:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230007AbjCIRSl (ORCPT ); Thu, 9 Mar 2023 12:18:41 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6AF31F5DD; Thu, 9 Mar 2023 09:17:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 596F2B82030; Thu, 9 Mar 2023 17:17:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85C2DC433EF; Thu, 9 Mar 2023 17:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678382239; bh=8OpMiuFsLUs9b5ZQq99zLr0Ompp5aq1AI4vSPjspTJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G8bbLHxEAOOHrkmZiSf4rg4PUHlHCT04//Su4jCE6KK4/GYoFEiAtm5xEQ4JtThVK BnF0gsYpdq5b/Gbv5WpFvQK+BObWoKcSjDMqOXvtY2DZ5C2VwhVlg6Eq5y/ZlhrzW8 a9T855x9taZ8VgtVS0p+GTrg3wLcHWgDBTvVzDvhjlQfk/yJvMS95AzGYzMtyuGEP5 mxV1ynb6kdLYV9UWZ5my+T+WTnWpTdGVVQ51J8B3h6wDX6o8XUfqOED8jz0DcgwmQj wxaI9a7Pz1AIPMpQxucMCTwx3VagoSAbH5zMIzJBTvTkUniPhQAtucefhLIHmO7D6/ 5AWs/aEBsyaoA== Date: Thu, 9 Mar 2023 17:17:14 +0000 From: Lee Jones To: Mauro Carvalho Chehab Cc: Takashi Iwai , Hyunwoo Kim , kernel@tuxforce.de, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, cai.huoqing@linux.dev Subject: Re: [PATCH v3 0/4] Fix multiple race condition vulnerabilities in dvb-core and device driver Message-ID: <20230309171714.GS9667@google.com> References: <20221117045925.14297-1-imv4bel@gmail.com> <87lema8ocn.wl-tiwai@suse.de> <20230307103659.GA347928@google.com> <20230309011525.49ac3399@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230309011525.49ac3399@coco.lan> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, 09 Mar 2023, Mauro Carvalho Chehab wrote: > Em Tue, 7 Mar 2023 10:36:59 +0000 > Lee Jones escreveu: > > > On Tue, 28 Feb 2023, Lee Jones wrote: > > > > > On Wed, 22 Feb 2023, Lee Jones wrote: > > > > > > > On Tue, 10 Jan 2023, Takashi Iwai wrote: > > > > > > > > > On Thu, 17 Nov 2022 05:59:21 +0100, > > > > > Hyunwoo Kim wrote: > > > > > > > > > > > > Dear, > > > > > > > > > > > > This patch set is a security patch for various race condition vulnerabilities that occur > > > > > > in 'dvb-core' and 'ttusb_dec', a dvb-based device driver. > > > > > > > > > > > > > > > > > > # 1. media: dvb-core: Fix use-after-free due to race condition occurring in dvb_frontend > > > > > > This is a security patch for a race condition that occurs in the dvb_frontend system of dvb-core. > > > > > > > > > > > > The race condition that occurs here will occur with _any_ device driver using dvb_frontend. > > > > > > > > > > > > The race conditions that occur in dvb_frontend are as follows > > > > > > > > [...] > > > > > > > > > > # 4. media: ttusb-dec: Fix memory leak in ttusb_dec_exit_dvb() > > > > > > This is a patch for a memory leak that occurs in the ttusb_dec_exit_dvb() function. > > > > > > > > > > > > Because ttusb_dec_exit_dvb() does not call dvb_frontend_detach(), > > > > > > several fe related structures are not kfree()d. > > > > > > > > > > > > Users can trigger a memory leak just by repeating connecting and disconnecting > > > > > > the ttusb_dec device. > > > > > > > > > > > > > > > > > > Finally, most of these patches are similar to this one, the security patch for > > > > > > CVE-2022-41218 that I reported: > > > > > > https://lore.kernel.org/linux-media/20221031100245.23702-1-tiwai@suse.de/ > > > > > > > > > > > > > > > > > > Regards, > > > > > > Hyunwoo Kim > > > > > > > > > > Are those issues still seen with the latest 6.2-rc kernel? > > > > > I'm asking because there have been a few fixes in dvb-core to deal > > > > > with some UAFs. > > > > > > > > > > BTW, Mauro, the issues are tagged with several CVE's: > > > > > CVE-2022-45884, CVE-2022-45886, CVE-2022-45885, CVE-2022-45887. > > > > > > > > Was there an answer to this question? > > > > > > > > Rightly or wrongly this patch is still being touted as the fix for some > > > > reported CVEs [0]. > > > > > > > > Is this patch still required or has it been superseded? If the later, > > > > which patch superseded it? > > > > > > > > Thanks. > > > > > > > > [0] https://nvd.nist.gov/vuln/detail/CVE-2022-45886 > > > > > > Have these issues been fixed already? > > > > > > If not, is this patch set due to be merged or reviewed? > > > > Still nothing heard from the author or any maintainer. > > We're currently lacking a sub-maintainer for dvb. Changes at the > DVB mutexes have been problematic and require tests on some > devices, specially on those with multiple frontends. > > I'll try to find some time to review and test those patches. Thank you Mauro, I fully appreciate the struggles and the effort. > > I'd take this as a hint if I had any social skills! > > > > Please could someone provide me with a status report on these patches? > > > > They appear to have CVEs associated with them. Have they been fixed? > > Thanks, > Mauro -- Lee Jones [李琼斯]