From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tom Rix <trix@redhat.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH] thunderbolt: rename shadowed variables bit to interrupt_bit and auto_clear_bit
Date: Thu, 16 Mar 2023 12:37:44 +0200 [thread overview]
Message-ID: <20230316103744.GS62143@black.fi.intel.com> (raw)
In-Reply-To: <20230316102048.GR62143@black.fi.intel.com>
On Thu, Mar 16, 2023 at 12:20:48PM +0200, Mika Westerberg wrote:
> +Cc Mario
>
> On Wed, Mar 15, 2023 at 06:04:50PM -0400, Tom Rix wrote:
> > cppcheck reports
> > drivers/thunderbolt/nhi.c:74:7: style: Local variable 'bit' shadows outer variable [shadowVariable]
> > int bit;
> > ^
> > drivers/thunderbolt/nhi.c:66:6: note: Shadowed declaration
> > int bit = ring_interrupt_index(ring) & 31;
> > ^
> > drivers/thunderbolt/nhi.c:74:7: note: Shadow variable
> > int bit;
> > ^
> > For readablity rename the outer to interrupt_bit and the innner
> > to auto_clear_bit.
>
> Thanks for the patch! Yeah, this did not show up in any of the kbuild
> tests perhaps they are missing cppcheck :(
>
> I'm thinking that I'll just move the two commits from "fixes" to "next"
> and add this one on top (and drop the stable tags) as the code that we
> should be sending to stable should not need additional fixes IMHO. I
> know Mario is on vacation so probably cannot answer here so let's deal
> with this when he is back.
Applied to thunderbolt.git/next (along with the two commits from Mario).
next prev parent reply other threads:[~2023-03-16 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 22:04 [PATCH] thunderbolt: rename shadowed variables bit to interrupt_bit and auto_clear_bit Tom Rix
2023-03-16 10:20 ` Mika Westerberg
2023-03-16 10:37 ` Mika Westerberg [this message]
2023-03-19 1:33 ` Mario Limonciello
2023-03-20 7:42 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316103744.GS62143@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).