From: Roger Quadros <rogerq@kernel.org>
To: Thinh.Nguyen@synopsys.com, stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, vigneshr@ti.com, srk@ti.com,
r-gunasekaran@ti.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Roger Quadros <rogerq@kernel.org>
Subject: [RFC PATCH 2/2] usb: dwc3: Support 'snps,gadget-keep-connect-sys-sleep' feature
Date: Mon, 20 Mar 2023 11:34:47 +0200 [thread overview]
Message-ID: <20230320093447.32105-3-rogerq@kernel.org> (raw)
In-Reply-To: <20230320093447.32105-1-rogerq@kernel.org>
Implement 'snps,gadget-keep-connect-sys-sleep' property.
Do not stop the gadget controller and disconnect if this
property is present and we are connected to a USB Host.
Prevent System sleep if Gadget is not in USB suspend.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
drivers/usb/dwc3/core.c | 25 +++++++++++++++++++------
drivers/usb/dwc3/core.h | 2 ++
drivers/usb/dwc3/gadget.c | 25 +++++++++++++++++++++++--
3 files changed, 44 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 476b63618511..a47bbaa27302 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1575,6 +1575,9 @@ static void dwc3_get_properties(struct dwc3 *dwc)
dwc->dis_split_quirk = device_property_read_bool(dev,
"snps,dis-split-quirk");
+ dwc->gadget_keep_connect_sys_sleep = device_property_read_bool(dev,
+ "snps,gadget-keep-connect-sys-sleep");
+
dwc->lpm_nyet_threshold = lpm_nyet_threshold;
dwc->tx_de_emphasis = tx_de_emphasis;
@@ -2027,14 +2030,20 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg)
{
unsigned long flags;
u32 reg;
+ int ret;
switch (dwc->current_dr_role) {
case DWC3_GCTL_PRTCAP_DEVICE:
if (pm_runtime_suspended(dwc->dev))
break;
- dwc3_gadget_suspend(dwc);
+ ret = dwc3_gadget_suspend(dwc);
+ if (ret) {
+ dev_err(dwc->dev, "gadget not suspended: %d\n", ret);
+ return ret;
+ }
synchronize_irq(dwc->irq_gadget);
- dwc3_core_exit(dwc);
+ if(!dwc->gadget_keep_connect_sys_sleep)
+ dwc3_core_exit(dwc);
break;
case DWC3_GCTL_PRTCAP_HOST:
if (!PMSG_IS_AUTO(msg) && !device_may_wakeup(dwc->dev)) {
@@ -2088,11 +2097,15 @@ static int dwc3_resume_common(struct dwc3 *dwc, pm_message_t msg)
switch (dwc->current_dr_role) {
case DWC3_GCTL_PRTCAP_DEVICE:
- ret = dwc3_core_init_for_resume(dwc);
- if (ret)
- return ret;
+ if (!dwc->gadget_keep_connect_sys_sleep)
+ {
+ ret = dwc3_core_init_for_resume(dwc);
+ if (ret)
+ return ret;
+
+ dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_DEVICE);
+ }
- dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_DEVICE);
dwc3_gadget_resume(dwc);
break;
case DWC3_GCTL_PRTCAP_HOST:
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 582ebd9cf9c2..f84bac815bed 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1328,6 +1328,8 @@ struct dwc3 {
unsigned dis_split_quirk:1;
unsigned async_callbacks:1;
+ unsigned gadget_keep_connect_sys_sleep:1;
+
u16 imod_interval;
int max_cfg_eps;
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 3c63fa97a680..8062e44f63f6 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4572,12 +4572,23 @@ void dwc3_gadget_exit(struct dwc3 *dwc)
int dwc3_gadget_suspend(struct dwc3 *dwc)
{
unsigned long flags;
+ int link_state;
if (!dwc->gadget_driver)
return 0;
- dwc3_gadget_run_stop(dwc, false, false);
+ if (dwc->gadget_keep_connect_sys_sleep && dwc->connected) {
+ link_state = dwc3_gadget_get_link_state(dwc);
+ /* Prevent PM Sleep if not in U3/L2 */
+ if (link_state != DWC3_LINK_STATE_U3)
+ return -EBUSY;
+
+ /* don't stop/disconnect */
+ dwc3_gadget_disable_irq(dwc);
+ return 0;
+ }
+ dwc3_gadget_run_stop(dwc, false, false);
spin_lock_irqsave(&dwc->lock, flags);
dwc3_disconnect_gadget(dwc);
__dwc3_gadget_stop(dwc);
@@ -4588,11 +4599,21 @@ int dwc3_gadget_suspend(struct dwc3 *dwc)
int dwc3_gadget_resume(struct dwc3 *dwc)
{
- int ret;
+ int ret;
+ irqreturn_t irq_t;
if (!dwc->gadget_driver || !dwc->softconnect)
return 0;
+ if (dwc->gadget_keep_connect_sys_sleep && dwc->connected) {
+ dwc3_gadget_enable_irq(dwc);
+ /* check pending events */
+ irq_t = dwc3_check_event_buf(dwc->ev_buf);
+ if (irq_t == IRQ_WAKE_THREAD)
+ dwc3_process_event_buf(dwc->ev_buf);
+ return 0;
+ }
+
ret = __dwc3_gadget_start(dwc);
if (ret < 0)
goto err0;
--
2.34.1
next prev parent reply other threads:[~2023-03-20 9:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:34 [RFC PATCH 0/2] usb: dwc3: Support wake-up from USB suspend Roger Quadros
2023-03-20 9:34 ` [RFC PATCH 1/2] dt-bindings: usb: snps,dwc3: Add 'snps,gadget-keep-connect-sys-sleep' Roger Quadros
2023-03-20 13:11 ` Rob Herring
2023-03-20 13:22 ` Rob Herring
2023-03-21 9:44 ` Roger Quadros
2023-03-20 9:34 ` Roger Quadros [this message]
2023-03-20 18:52 ` [RFC PATCH 2/2] usb: dwc3: Support 'snps,gadget-keep-connect-sys-sleep' feature Thinh Nguyen
2023-03-21 10:20 ` Roger Quadros
2023-03-21 18:43 ` Thinh Nguyen
2023-03-21 19:05 ` Thinh Nguyen
2023-03-22 8:11 ` Roger Quadros
2023-03-22 17:31 ` Thinh Nguyen
2023-03-23 2:17 ` Thinh Nguyen
2023-03-23 9:29 ` Roger Quadros
2023-03-23 20:51 ` Thinh Nguyen
2023-03-31 11:05 ` Roger Quadros
2023-04-03 23:37 ` Thinh Nguyen
2023-04-04 8:01 ` Roger Quadros
2023-04-04 21:53 ` Thinh Nguyen
2023-04-05 8:56 ` Roger Quadros
2023-04-06 1:38 ` Thinh Nguyen
2023-04-12 7:46 ` Roger Quadros
2023-04-12 20:59 ` Thinh Nguyen
2023-04-13 11:31 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320093447.32105-3-rogerq@kernel.org \
--to=rogerq@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=srk@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).