From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1FAC76188 for ; Wed, 5 Apr 2023 18:07:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233903AbjDESHa (ORCPT ); Wed, 5 Apr 2023 14:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjDESH2 (ORCPT ); Wed, 5 Apr 2023 14:07:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C3D67D95; Wed, 5 Apr 2023 11:07:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 908CC627FF; Wed, 5 Apr 2023 18:06:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E652C433D2; Wed, 5 Apr 2023 18:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680718011; bh=d1Pk2ZSYTsDyUcVK0NMJYETf7DI5PZ43iawuHurWjGI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R9lwLOprtJ5WlxJMGh1fasd6QZKtIMsz8vJnGVx5k76eWHAL0wXRRa/ns3IYbbci1 J63ShGUSB0vDMEF1+uhtKfslzWc2j7hmES3KH+Tl0ZbNvUrjwL59nq2VwFqsdQEsod i0qwv2jVZOVpaYsuFMLijGfS6cyD2npQvI6YWwSY= Date: Wed, 5 Apr 2023 20:06:48 +0200 From: Greg Kroah-Hartman To: Bastien Nocera Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org, Alan Stern , Benjamin Tissoires , Filipe =?iso-8859-1?Q?La=EDns?= , Nestor Lopez Casado , Stephen Rothwell Subject: Re: [PATCH v2] USB: core: Fix docs warning caused by wireless_status feature Message-ID: <2023040541-decipher-chowtime-42a3@gregkh> References: <20230405092754.36579-1-hadess@hadess.net> <2023040554-obscurity-latter-b12b@gregkh> <8ee84f3383fb074f031b88c4f030757667635d96.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8ee84f3383fb074f031b88c4f030757667635d96.camel@hadess.net> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Apr 05, 2023 at 08:03:16PM +0200, Bastien Nocera wrote: > On Wed, 2023-04-05 at 19:13 +0200, Greg Kroah-Hartman wrote: > > On Wed, Apr 05, 2023 at 11:27:54AM +0200, Bastien Nocera wrote: > > > Fix wrongly named 'dev' parameter in doc block, should have been > > > iface: > > > drivers/usb/core/message.c:1939: warning: Function parameter or > > > member 'iface' not described in 'usb_set_wireless_status' > > > drivers/usb/core/message.c:1939: warning: Excess function parameter > > > 'dev' description in 'usb_set_wireless_status' > > > > > > And fix missing struct member doc in kernel API, and reorder to > > > match struct: > > > include/linux/usb.h:270: warning: Function parameter or member > > > 'wireless_status_work' not described in 'usb_interface' > > > > > > Reported-by: Stephen Rothwell > > > Link: > > > https://lore.kernel.org/linux-next/20230405114807.5a57bf46@canb.auug.org.au/T/#t > > > Fixes: 0a4db185f078 ("USB: core: Add API to change the > > > wireless_status") > > > > I do not see that git commit id anywhere, where is it from?  What > > tree? > > > > Ah, input tree, not much I can do there... > > Yes, it's from the hid tree. > > Benjamin is waiting on either Alan or yourself ack'ing the changes > before pushing it through the hid tree, to avoid stepping on somebody > else's toes. > > The patch seems to fix the warnings in my local tests, let me know if > you have any comments about the wording. Nope: Acked-by: Greg Kroah-Hartman