Linux USB
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Stanley Chang <stanley_chang@realtek.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,fixed_dwc3_globals_regs_start' quirk
Date: Sat, 8 Apr 2023 02:51:21 +0000	[thread overview]
Message-ID: <20230408025119.jmiosqxbh2lzjefy@synopsys.com> (raw)
In-Reply-To: <20230407060703.19469-2-stanley_chang@realtek.com>

On Fri, Apr 07, 2023, Stanley Chang wrote:
> Add a new 'snps,fixed_dwc3_globals_regs_start' DT to dwc3 core to remap
> the global register start address
> 
> The RTK DHC SoCs were designed the global register address offset at 0x8100.
> The default address is at DWC3_GLOBALS_REGS_START (0xc100).
> Therefore, add the property of device-tree to adjust this start address.
> 
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index be36956af53b..a5599d977db6 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -359,6 +359,13 @@ properties:
>      items:
>        enum: [1, 4, 8, 16, 32, 64, 128, 256]
>  
> +  snps,fixed_dwc3_globals_regs_start:
> +    description:
> +      value for remapping global register start address. For some dwc3
> +      controller, the dwc3 global register start address is not at
> +      default DWC3_GLOBALS_REGS_START (0xc100). This property is added to
> +      adjust the address.
> +
>    port:
>      $ref: /schemas/graph.yaml#/properties/port
>      description:
> -- 
> 2.34.1
> 

This isn't common. Can we check through compatible string instead?

Thanks,
Thinh

  reply	other threads:[~2023-04-08  2:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07  6:07 [PATCH v1 1/2] usb: dwc3: core: add support for remapping global register start address Stanley Chang
2023-04-07  6:07 ` [PATCH v1 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,fixed_dwc3_globals_regs_start' quirk Stanley Chang
2023-04-08  2:51   ` Thinh Nguyen [this message]
2023-04-10  3:59     ` Stanley Chang[昌育德]
2023-04-08  2:08 ` [PATCH v1 1/2] usb: dwc3: core: add support for remapping global register start address Thinh Nguyen
2023-04-10  4:09   ` Stanley Chang[昌育德]
2023-04-11  1:27     ` Thinh Nguyen
2023-04-11  3:11       ` Stanley Chang[昌育德]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230408025119.jmiosqxbh2lzjefy@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stanley_chang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox