From: Greg KH <gregkh@linuxfoundation.org>
To: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: typec: intel_pmc_mux: Expose IOM port status to debugfs
Date: Wed, 19 Apr 2023 15:13:28 +0200 [thread overview]
Message-ID: <2023041928-step-salsa-3cba@gregkh> (raw)
In-Reply-To: <20230419130345.1689915-1-rajat.khandelwal@linux.intel.com>
On Wed, Apr 19, 2023 at 06:33:45PM +0530, Rajat Khandelwal wrote:
> IOM status has a crucial role during debugging to check the
> current state of the type-C port.
> There are ways to fetch the status, but all those require the
> IOM port status offset, which could change with platform.
>
> Make a debugfs directory for intel_pmc_mux and expose the status
> under it per port basis.
>
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
> ---
>
> v3: Allocate the debugfs directory name for the platform device with
> its ACPI dev name included
{sigh} No, sorry, this is not correct.
Also, you did not properly follow the rules that all Intel kernel
developers are supposed to follow. Please consult your local kernel
developer team and do so before sending any more kernel patches out.
greg k-h
prev parent reply other threads:[~2023-04-19 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 13:03 [PATCH v3] usb: typec: intel_pmc_mux: Expose IOM port status to debugfs Rajat Khandelwal
2023-04-19 13:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023041928-step-salsa-3cba@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rajat.khandelwal@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).