Linux USB
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: dwc3 gadget: controller stop times out on system sleep
Date: Wed, 26 Apr 2023 20:01:40 +0000	[thread overview]
Message-ID: <20230426200140.xa4unnbaw2vog2je@synopsys.com> (raw)
In-Reply-To: <24c9f271-ed74-fffa-a49f-6e83da857593@kernel.org>

Hi,

On Wed, Apr 26, 2023, Roger Quadros wrote:
> Hi Thinh,
> 
> On Linux kernel v6.3
> Test procedure: 
> 
> - modprobe g_zero
> - Connect to PC host
> - systemctl suspend
> 
> A large delay of 3 seconds is observed. The delay comes from dwc3_gadget_suspend()->dwc3_gadget_run_stop() waiting for DWC3_DSTS_DEVCTRLHLT to be set.
> It returns -ETIMEDOUT.
> 
> Are we missing something to do a clean stop during suspend?
> 
> FYI. Unloading g_zero does not show this delay on stop.
> 
> cheers,
> -roger

When clearing run_stop bit and the controller doesn't halt, that usually
means there are active transfers/endpoints that aren't ended yet.

The dwc3_gadget_suspend() doesn't properly do all the cleanup before
clearing the run_stop bit. I think you just need to call
dwc3_gadget_soft_disconnect() in dwc3_gadget_suspend() to fix this.

Thanks,
Thinh

  reply	other threads:[~2023-04-26 20:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 16:17 dwc3 gadget: controller stop times out on system sleep Roger Quadros
2023-04-26 20:01 ` Thinh Nguyen [this message]
2023-04-27 16:26   ` Roger Quadros
2023-04-27 22:13     ` Thinh Nguyen
2023-04-28 12:04       ` Roger Quadros
2023-04-28 18:33         ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230426200140.xa4unnbaw2vog2je@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rogerq@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox