From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25145C7EE22 for ; Sun, 14 May 2023 14:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234676AbjENO4i (ORCPT ); Sun, 14 May 2023 10:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjENO4g (ORCPT ); Sun, 14 May 2023 10:56:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF65FBC; Sun, 14 May 2023 07:56:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 616C760909; Sun, 14 May 2023 14:56:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1491AC433EF; Sun, 14 May 2023 14:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684076194; bh=AmdXfneDhX6PyNFaK8zWLgSifqZ7PMoHdrPWeD+7pRk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=reVIA0FrKLDwQe0pNvfstvc/ceW7oqYmOffF5WCLxu49J1OOziqpf9NvMm0KMrWVQ 6xZsJEWg6wbjbbiD/1Vax+ug5JY39Si00U9dUxN9RM+JKB7PooajqnrXnW4oJzWqnR qT0f0MO/YTZ33gf5Y9DWOuLAqWoprESdC+1yQdUzfukzz7Rqzb+xkYhg+OX3+UxAIP NVdyIi0EaiFJFMg26wB0hDtbQn643GBdfk+1LTz0o7BsiqEtHqqRtNtb8GVzI4lgwW /4RZXKwDmEbDlZASKub207hLNbFosOxmkILUOa26A5svutvuBVOcJ+88cwtWj18oSB RocmqA/DSR28Q== Date: Sun, 14 May 2023 15:56:29 +0100 From: Mauro Carvalho Chehab To: Lee Jones Cc: Takashi Iwai , Hyunwoo Kim , kernel@tuxforce.de, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, cai.huoqing@linux.dev Subject: Re: [PATCH v3 0/4] Fix multiple race condition vulnerabilities in dvb-core and device driver Message-ID: <20230514155629.7f453429@sal.lan> In-Reply-To: <20230513190901.0f403933@sal.lan> References: <20221117045925.14297-1-imv4bel@gmail.com> <87lema8ocn.wl-tiwai@suse.de> <20230307103659.GA347928@google.com> <20230309011525.49ac3399@coco.lan> <20230309171714.GS9667@google.com> <20230513190901.0f403933@sal.lan> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Em Sat, 13 May 2023 19:09:01 +0100 Mauro Carvalho Chehab escreveu: > Hi Lee, > > Em Thu, 9 Mar 2023 17:17:14 +0000 > Lee Jones escreveu: > > > > > Still nothing heard from the author or any maintainer. > > > > > > We're currently lacking a sub-maintainer for dvb. Changes at the > > > DVB mutexes have been problematic and require tests on some > > > devices, specially on those with multiple frontends. > > > > > > I'll try to find some time to review and test those patches. > > > > Thank you Mauro, I fully appreciate the struggles and the effort. > > It took more time than I originally anticipated, as I had to setup > a way to test it here with some DVB-T devices, but I reviewed the > code and tested it. > > I'm placing the patches I picked at this series: > > https://lore.kernel.org/lkml/53558de2b5c4f4ee6bfcfbe34e27071c2d0073d5.1684000646.git.mchehab@kernel.org/T/#t > > They seemed to work fine. I tested using two devices: > > USB ID 2013:0246 PCTV Systems PCTV 74E > USB ID 2040:5200 Hauppauge NovaT 500Stick > > The second one has two DVB-T independent devices on it. > > I did some tests of removing and re-inserting them with the > devices closed and with the device opened and streamed. I didn't > find any regressions. I didn't try to use kmemleak or KASAN to > detect UAF conditions, though. Did some tests today: neither KASAN nor kmemleak pointed any issue. I found a few issues on one of the patches: some mutex unbalance at dvb_frontend at the error path. Already updated the patches to fix it. Should be merging at the media subsystem today and send a PR upstream along the next week with the fixes. Regards, Mauro