* [PATCH v3 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type
@ 2023-05-15 16:20 Frank Li
2023-05-16 7:44 ` Krzysztof Kozlowski
2023-05-16 12:45 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2023-05-15 16:20 UTC (permalink / raw)
To: shawnguo, Peter Chen, Pawel Laszczak, Roger Quadros,
Aswath Govindraju, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Felipe Balbi,
open list:CADENCE USB3 DRD IP DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using
device_property_read_u16(). It resulted in 0 if a 32bit value was used
in dts. This commit fixes the dt binding doc to declare it as u16.
Cc: stable@vger.kernel.org
Fixes: 68989fe1c39d ("dt-bindings: usb: Convert cdns-usb3.txt to YAML schema")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- add fixes tag and cc stable
Change from v1 to v2
- new patch
Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
index cae46c4982ad..69a93a0722f0 100644
--- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
+++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
@@ -64,7 +64,7 @@ properties:
description:
size of memory intended as internal memory for endpoints
buffers expressed in KB
- $ref: /schemas/types.yaml#/definitions/uint32
+ $ref: /schemas/types.yaml#/definitions/uint16
cdns,phyrst-a-enable:
description: Enable resetting of PHY if Rx fail is detected
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type
2023-05-15 16:20 [PATCH v3 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Frank Li
@ 2023-05-16 7:44 ` Krzysztof Kozlowski
2023-05-16 12:45 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-16 7:44 UTC (permalink / raw)
To: Frank Li, shawnguo, Peter Chen, Pawel Laszczak, Roger Quadros,
Aswath Govindraju, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Felipe Balbi,
open list:CADENCE USB3 DRD IP DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 15/05/2023 18:20, Frank Li wrote:
> In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using
> device_property_read_u16(). It resulted in 0 if a 32bit value was used
> in dts. This commit fixes the dt binding doc to declare it as u16.
>
> Cc: stable@vger.kernel.org
> Fixes: 68989fe1c39d ("dt-bindings: usb: Convert cdns-usb3.txt to YAML schema")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type
2023-05-15 16:20 [PATCH v3 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Frank Li
2023-05-16 7:44 ` Krzysztof Kozlowski
@ 2023-05-16 12:45 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-05-16 12:45 UTC (permalink / raw)
To: Frank Li
Cc: Peter Chen, Pawel Laszczak, Roger Quadros, Aswath Govindraju,
Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Felipe Balbi, open list:CADENCE USB3 DRD IP DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Mon, May 15, 2023 at 12:20:52PM -0400, Frank Li wrote:
> In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using
> device_property_read_u16(). It resulted in 0 if a 32bit value was used
> in dts. This commit fixes the dt binding doc to declare it as u16.
>
> Cc: stable@vger.kernel.org
> Fixes: 68989fe1c39d ("dt-bindings: usb: Convert cdns-usb3.txt to YAML schema")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Applied both and will send them as fixes for v6.4-rc through arm-soc tree.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-16 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-15 16:20 [PATCH v3 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Frank Li
2023-05-16 7:44 ` Krzysztof Kozlowski
2023-05-16 12:45 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).