Re: [PATCH 40/97] usb: gadget/renesas_usbf: Convert to platform remove callback returning void

[Herve Codina <herve.codina@bootlin.com>]

On Thu, 18 May 2023 01:01:42 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/usb/gadget/udc/renesas_usbf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c
> index 84ac9fe4ce7f..6cd0af83e91e 100644
> --- a/drivers/usb/gadget/udc/renesas_usbf.c
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c
> @@ -3361,15 +3361,13 @@ static int usbf_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int usbf_remove(struct platform_device *pdev)
> +static void usbf_remove(struct platform_device *pdev)
>  {
>  	struct usbf_udc *udc = platform_get_drvdata(pdev);
>  
>  	usb_del_gadget_udc(&udc->gadget);
>  
>  	pm_runtime_put(&pdev->dev);
> -
> -	return 0;
>  }
>  
>  static const struct of_device_id usbf_match[] = {
> @@ -3385,7 +3383,7 @@ static struct platform_driver udc_driver = {
>  		.of_match_table = usbf_match,
>  	},
>  	.probe          = usbf_probe,
> -	.remove         = usbf_remove,
> +	.remove_new     = usbf_remove,
>  };
>  
>  module_platform_driver(udc_driver);

Acked-by: Herve Codina <herve.codina@bootlin.com>

Thanks,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com