* [PATCH] usb: typec: mux: Fix extraneous semicolon
@ 2023-06-01 21:33 Arnd Bergmann
2023-06-02 7:45 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-06-01 21:33 UTC (permalink / raw)
To: Greg Kroah-Hartman, Heikki Krogerus, Prashant Malani,
Bjorn Andersson
Cc: Arnd Bergmann, linux-usb, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A recent patch introduced a typo in the fwnode_typec_mux_get()
stub function that causes a build failure in some configurations:
In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token
include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]
Fixes: 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/linux/usb/typec_mux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
index 11bfa314529fd..2489a7857d8e1 100644
--- a/include/linux/usb/typec_mux.h
+++ b/include/linux/usb/typec_mux.h
@@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
#else
-static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
+static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
{
return NULL;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: mux: Fix extraneous semicolon
2023-06-01 21:33 [PATCH] usb: typec: mux: Fix extraneous semicolon Arnd Bergmann
@ 2023-06-02 7:45 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-06-02 7:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Heikki Krogerus, Prashant Malani, Bjorn Andersson, Arnd Bergmann,
linux-usb, linux-kernel
On Thu, Jun 01, 2023 at 11:33:37PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch introduced a typo in the fwnode_typec_mux_get()
> stub function that causes a build failure in some configurations:
>
> In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
> include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token
> include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]
>
> Fixes: 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> include/linux/usb/typec_mux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
> index 11bfa314529fd..2489a7857d8e1 100644
> --- a/include/linux/usb/typec_mux.h
> +++ b/include/linux/usb/typec_mux.h
> @@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
>
> #else
>
> -static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
> +static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
> {
> return NULL;
> }
> --
> 2.39.2
>
Should already be fixed in my tree, and in the next linux-next, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-02 7:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 21:33 [PATCH] usb: typec: mux: Fix extraneous semicolon Arnd Bergmann
2023-06-02 7:45 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox