From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Prashant Malani <pmalani@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: mux: Fix extraneous semicolon
Date: Fri, 2 Jun 2023 08:45:26 +0100 [thread overview]
Message-ID: <2023060210-foam-flip-6f2d@gregkh> (raw)
In-Reply-To: <20230601213342.3334659-1-arnd@kernel.org>
On Thu, Jun 01, 2023 at 11:33:37PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch introduced a typo in the fwnode_typec_mux_get()
> stub function that causes a build failure in some configurations:
>
> In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
> include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token
> include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]
>
> Fixes: 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> include/linux/usb/typec_mux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
> index 11bfa314529fd..2489a7857d8e1 100644
> --- a/include/linux/usb/typec_mux.h
> +++ b/include/linux/usb/typec_mux.h
> @@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
>
> #else
>
> -static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
> +static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
> {
> return NULL;
> }
> --
> 2.39.2
>
Should already be fixed in my tree, and in the next linux-next, sorry.
greg k-h
prev parent reply other threads:[~2023-06-02 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 21:33 [PATCH] usb: typec: mux: Fix extraneous semicolon Arnd Bergmann
2023-06-02 7:45 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023060210-foam-flip-6f2d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox