From: Peter Chen <peter.chen@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-imx@nxp.com, jun.li@nxp.com
Subject: Re: [PATCH 3/3] usb: chipidea: imx: add missing USB PHY DPDM wakeup setting
Date: Mon, 5 Jun 2023 07:27:38 +0800 [thread overview]
Message-ID: <20230604232738.GI258497@nchen-desktop> (raw)
In-Reply-To: <20230517081907.3410465-3-xu.yang_2@nxp.com>
On 23-05-17 16:19:07, Xu Yang wrote:
> USB PHY DPDM wakeup bit is enabled by default, when USB wakeup
> is not required(/sys/.../wakeup is disabled), this bit should be
> disabled, otherwise we will have unexpected wakeup if do USB device
> connect/disconnect while system sleep.
> This bit can be enabled for both host and device mode.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index 9566022a2183..9ee9621e2ccc 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -134,7 +134,7 @@
> #define TXVREFTUNE0_MASK (0xf << 20)
>
> #define MX6_USB_OTG_WAKEUP_BITS (MX6_BM_WAKEUP_ENABLE | MX6_BM_VBUS_WAKEUP | \
> - MX6_BM_ID_WAKEUP)
> + MX6_BM_ID_WAKEUP | MX6SX_BM_DPDM_WAKEUP_EN)
Acked-by: Peter Chen <peter.chen@kernel.org>
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2023-06-04 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 8:19 [PATCH 1/3] usb: chipidea: imx: remove one duplicated reg define Xu Yang
2023-05-17 8:19 ` [PATCH 2/3] usb: chipidea: imx: turn off vbus comparator when suspend Xu Yang
2023-06-04 23:25 ` Peter Chen
2023-05-17 8:19 ` [PATCH 3/3] usb: chipidea: imx: add missing USB PHY DPDM wakeup setting Xu Yang
2023-06-04 23:27 ` Peter Chen [this message]
2023-06-04 23:25 ` [PATCH 1/3] usb: chipidea: imx: remove one duplicated reg define Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230604232738.GI258497@nchen-desktop \
--to=peter.chen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox