Re: [PATCH 0/9] fs: add some missing ctime updates

Greg Kroah-Hartman
2023-06-09T13:11:03Z

On Fri, Jun 09, 2023 at 08:50:14AM -0400, Jeff Layton wrote:
> While working on a patch series to change how we handle the ctime, I
> found a number of places that update the mtime without a corresponding
> ctime update. POSIX requires that when the mtime is updated that the
> ctime also be updated.
>
> Note that these are largely untested other than for compilation, so
> please review carefully. These are a preliminary set for the upcoming
> rework of how we handle the ctime.
>
> None of these seem to be very crucial, but it would be nice if
> various maintainers could pick these up for v6.5. Please let me know if
> you do.
>
> Jeff Layton (9):
> ibmvmc: update ctime in conjunction with mtime on write
> usb: update the ctime as well when updating mtime after an ioctl
> autofs: set ctime as well when mtime changes on a dir
> bfs: update ctime in addition to mtime when adding entries
> efivarfs: update ctime when mtime changes on a write
> exfat: ensure that ctime is updated whenever the mtime is
> gfs2: update ctime when quota is updated
> apparmor: update ctime whenever the mtime changes on an inode
> cifs: update the ctime on a partial page write
>
> drivers/misc/ibmvmc.c | 2 +-
> drivers/usb/core/devio.c | 16 ++++++++--------
> fs/autofs/root.c | 6 +++---
> fs/bfs/dir.c | 2 +-
> fs/efivarfs/file.c | 2 +-
> fs/exfat/namei.c | 8 ++++----
> fs/gfs2/quota.c | 2 +-
> fs/smb/client/file.c | 2 +-
> security/apparmor/apparmorfs.c | 7 +++++--
> security/apparmor/policy_unpack.c | 11 +++++++----
> 10 files changed, 32 insertions(+), 26 deletions(-)
>
> --
> 2.40.1
>

All of these need commit log messages, didn't checkpatch warn you about
that?

thanks,

greg k-h