From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0A3EB64D8 for ; Wed, 14 Jun 2023 06:19:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234637AbjFNGSn (ORCPT ); Wed, 14 Jun 2023 02:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233905AbjFNGSk (ORCPT ); Wed, 14 Jun 2023 02:18:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 030CA1BC5; Tue, 13 Jun 2023 23:18:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B02963357; Wed, 14 Jun 2023 06:18:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60A47C433C8; Wed, 14 Jun 2023 06:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686723517; bh=p8cT3KGfD9ibYP9ueE0C4NUvbnC63jpDlwsJbEABoLI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wAmAyOwaJxR1VlRrX8Y81G7/mRK8AJt6LkRLuRuhnpihiVABk0MkC22f+CVz5rTpg 1/t7xBznBl+/6TjX1D3LqnBzRMVTHp/kRzof3AHvOe5WIHODMF3wEfZSqH0MU1xvYL zskGDpUomY90FAw4lST7rP78I2PgxAd/PbrzHu4U= Date: Wed, 14 Jun 2023 08:18:34 +0200 From: Greg KH To: Pawel Laszczak Cc: "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "Daisy.Barrera@siriusxm.com" , "Cliff.Holden@siriusxm.com" , "tony@atomide.com" , "jdelvare@suse.de" , "neal_liu@aspeedtech.com" , "linus.walleij@linaro.org" , "egtvedt@samfundet.no" , "biju.das.jz@bp.renesas.com" , "herve.codina@bootlin.com" Subject: Re: [PATCH v4 4/4] MAINTAINERS: add Cadence USBHS driver entry Message-ID: <2023061442-showgirl-cradling-159d@gregkh> References: <20230602102644.77470-1-pawell@cadence.com> <20230602102644.77470-5-pawell@cadence.com> <2023061350-calcium-follow-8649@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jun 14, 2023 at 05:45:46AM +0000, Pawel Laszczak wrote: > > > > >On Fri, Jun 02, 2023 at 06:26:44AM -0400, Pawel Laszczak wrote: > >> Patch adds entry for USBHS (CDNS2) driver into MAINTARNERS file > >> > >> Signed-off-by: Pawel Laszczak > >> --- > >> MAINTAINERS | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS index > >> c269a15609e2..8b289d52d983 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -4523,6 +4523,12 @@ T: git > >git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git > >> F: drivers/usb/cdns3/ > >> X: drivers/usb/cdns3/cdns3* > >> > >> +CADENCE USBHS DRIVER > >> +M: Pawel Laszczak > >> +L: linux-usb@vger.kernel.org > >> +S: Maintained > > > >This isn't part of your job description? Why doesn't Cadence allow you to do > >that? That's not good on a bunch of levels, have you seen the > >Documentation/process/contribution-maturity-model.rst file yet? > > > > I have read it now, but I don't understand where I made mistake. > I guess that I should not be added as maintainer. Am I right? > > I responsible for: > 1. developing USBHS driver > 2. upstreaming USBH driver > 3. fixing issue detected by me or by our customers. It's the "S: Maintained" line I am curious about. "Maintained" means "Someone actually looks after it.", while if you put "Supported" that means "Someone is actually paid to look after this." The difference is the first is usually on your own time as a best-effort on your part, the second is that it is part of your job from your employer. If Cadence doesn't allow you to do maintaince work on company time, then the entry is correct as you wrote it. Otherwise you might want to change that. See the top of the MAINTAINERS file for the other options you have here for this field if neither of these are correct. thanks, greg k-h