From: Greg KH <gregkh@linuxfoundation.org>
To: Frank Wang <frank.wang@rock-chips.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
heikki.krogerus@linux.intel.com, sebastian.reichel@collabora.com,
heiko@sntech.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
huangtao@rock-chips.com, william.wu@rock-chips.com,
jianwei.zheng@rock-chips.com, yubing.zhang@rock-chips.com,
wmc@rock-chips.com
Subject: Re: usb: typec: tcpm: fix cc role at port reset
Date: Fri, 16 Jun 2023 08:06:00 +0200 [thread overview]
Message-ID: <2023061643-uplifting-sequester-0152@gregkh> (raw)
In-Reply-To: <f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com>
On Fri, Jun 16, 2023 at 11:03:14AM +0800, Frank Wang wrote:
> Hi Guenter,
>
> On 2023/6/16 10:27, Guenter Roeck wrote:
> > On 6/15/23 19:20, Frank Wang wrote:
> > > In the current implementation, the tcpm set CC1/CC2 role to open when
> > > it do port reset would cause the VBUS removed by the Type-C partner.
> > >
> > > This sets CC1/CC2 according to the default state of port to fix it.
> > >
> > > Comments are suggested by Guenter Roeck.
> > >
> >
> > I have no idea (recollection) of what I suggested here :-(
>
> Aha, this is also an old patch I have sent before, you suggested that the cc
> role should require some tweaking based on the port type or default state,
> do you remember it now?
Please version the patch, and provide the change information as
documented.
thanks,
greg k-h
prev parent reply other threads:[~2023-06-16 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 2:20 usb: typec: tcpm: fix cc role at port reset Frank Wang
2023-06-16 2:27 ` Guenter Roeck
2023-06-16 3:03 ` Frank Wang
2023-06-16 6:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061643-uplifting-sequester-0152@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=frank.wang@rock-chips.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jianwei.zheng@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sebastian.reichel@collabora.com \
--cc=william.wu@rock-chips.com \
--cc=wmc@rock-chips.com \
--cc=yubing.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox