From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7A1EB64DA for ; Mon, 19 Jun 2023 15:07:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230282AbjFSPH2 (ORCPT ); Mon, 19 Jun 2023 11:07:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbjFSPHT (ORCPT ); Mon, 19 Jun 2023 11:07:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B4A170C; Mon, 19 Jun 2023 08:06:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD7B860C72; Mon, 19 Jun 2023 15:06:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 004EFC433C8; Mon, 19 Jun 2023 15:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687187210; bh=ErWuQq2NfHQ3CyVJprCo+42/PXz4z1R0rTbz/ijpHOA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sg/HYWKa+WV9Xfp1laspMOtmWUUYp/1Ow6byBCHG7nu+3OOTZOuTDgZuXFTVJxO/C UCnS3UNoK535hnwuC+ZyUWW3sB5k9dDQMP+u8zV5hZYIVgw0o57FDkglJaqoBXEhdi ABxVOaq0Zbr6YnMARHLdLooAe9QzkrbL5dKkvCtI= Date: Mon, 19 Jun 2023 17:06:46 +0200 From: Greg Kroah-Hartman To: Dan Carpenter Cc: Badhri Jagan Sridharan , Alan Stern , Francesco Dolcini , Krishna Kurapati , Elson Roy Serrao , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] usb: gadget: udc: core: Fix double unlock in usb_gadget_activate() Message-ID: <2023061937-remedial-chrome-6c09@gregkh> References: <32e22952-8574-4120-979b-ebb6af5f54b4@moroto.mountain> <2023061959-volley-badland-81a2@gregkh> <031bd76e-7955-4a71-94fa-276d08d5ada5@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <031bd76e-7955-4a71-94fa-276d08d5ada5@kadam.mountain> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jun 19, 2023 at 05:46:28PM +0300, Dan Carpenter wrote: > On Mon, Jun 19, 2023 at 03:39:05PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 15, 2023 at 06:43:03PM +0300, Dan Carpenter wrote: > > > Do not call mutex_unlock(&gadget->udc->connect_lock) twice in a row. > > > > > > Fixes: 286d9975a838 ("usb: gadget: udc: core: Prevent soft_connect_store() race") > > > Signed-off-by: Dan Carpenter > > > --- > > > drivers/usb/gadget/udc/core.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > > > index 83fd1de14784..d58640a9d0ca 100644 > > > --- a/drivers/usb/gadget/udc/core.c > > > +++ b/drivers/usb/gadget/udc/core.c > > > @@ -878,8 +878,6 @@ int usb_gadget_activate(struct usb_gadget *gadget) > > > */ > > > if (gadget->connected) > > > ret = usb_gadget_connect_locked(gadget); > > > - mutex_unlock(&gadget->udc->connect_lock); > > > - > > > unlock: > > > mutex_unlock(&gadget->udc->connect_lock); > > > trace_usb_gadget_activate(gadget, ret); > > > -- > > > 2.39.2 > > > > > > > Does not apply to my tree :( > > No longer required. The patch was reverted. Ah good, thanks for checking.