From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DAEEB64DC for ; Wed, 21 Jun 2023 16:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230199AbjFUQBB (ORCPT ); Wed, 21 Jun 2023 12:01:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231777AbjFUQAy (ORCPT ); Wed, 21 Jun 2023 12:00:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E70119BE; Wed, 21 Jun 2023 09:00:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 963BC615BA; Wed, 21 Jun 2023 15:59:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 776A8C433C0; Wed, 21 Jun 2023 15:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687363198; bh=mHRta9tIJV2JDA/5J295h4GbkMjyOk5qKzU56OUj/sk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ef8MjNepoOxKJfpbzY04NICf1OgzrJvYyTtjCFUEJSUHj/8qey/p4CbAUNyZveqZT bm0jdMdQZE5OhNXnmpkUqw2ePKIN0f94/wJs/74eGqz+r8aY1S6ybaRKn99jshcW92 W1RJzagbkPcofo+4RCi0w14pEGsgJ2JKLubbpXd0= Date: Wed, 21 Jun 2023 17:59:55 +0200 From: Greg Kroah-Hartman To: Lei Yu Cc: Felipe Balbi , Joel Stanley , Andrew Jeffery , Henry Tian , Jakob Koschel , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Ryan Chen , Neal Liu , Benjamin Herrenschmidt Subject: Re: [PATCH] usb: gadget: aspeed: fix buffer overflow Message-ID: <2023062146-stony-lair-b6a3@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jun 21, 2023 at 08:02:14PM +0800, Lei Yu wrote: > On Wed, Dec 21, 2022 at 10:26 AM Lei Yu wrote: > > > > On Wed, Dec 21, 2022 at 10:17 AM Neal Liu wrote: > > > > > > > > Using rndis is able to set MTU to 2000, and the issue can be > > > > reproduced. > > > > > > > > USB ecm is also tested and it is possible to set MTU to 2000, and could > > > > reproduce the issue. > > > > So I think this patch is needed anyway. > > > > > > > > @Neal Liu Could you kindly help to verify the USB ECM case? > > > > > > How to set MTU to 2000 on USB ECM case? I remember last time I cannot set by using "ifconfig ..." > > > Regardless ECM or RNDIS, I agree this patch is still needed. > > > > You were able to set MTU to 2000 for RNDIS but not for NCM. > > @Greg Kroah-Hartman indicated that RNDIS should not be used anymore. > > So I tested ECM and verified it could set MTU 2000 and the issue could > > be reproduced. > > This patch fixes the kernel oops in the aspeed-vhub driver for both > USB ECM and RNDIS. > It now has an Acked-by from benh and Reviewed-by from neal_liu > > Should we merge this patch? Can you please resend it? thanks, greg k-h