From: Guiting Shen <aarongt.shen@gmail.com>
To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Guiting Shen <aarongt.shen@gmail.com>
Subject: [PATCH v2] usb: ohci-at91: Fix the unhandle interrupt when resume
Date: Mon, 26 Jun 2023 00:15:53 +0800 [thread overview]
Message-ID: <20230625161553.11073-1-aarongt.shen@gmail.com> (raw)
The ohci_hcd_at91_drv_suspend() sets ohci->rh_state to OHCI_RH_HALTED when
suspend which will let the ohci_irq() skip the interrupt after resume. And
nobody to handle this interrupt.
According to the comment in ohci_hcd_at91_drv_suspend(), it need to reset
when resume from suspend(MEM) to fix.
Signed-off-by: Guiting Shen <aarongt.shen@gmail.com>
---
drivers/usb/host/ohci-at91.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index b9ce8d80f20b..1a0356d9ea15 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -672,7 +672,12 @@ ohci_hcd_at91_drv_resume(struct device *dev)
else
at91_start_clock(ohci_at91);
- ohci_resume(hcd, false);
+ /*
+ * need to reset according to the comment of suspend routine,
+ * otherwise the ohci_irq would skip the interrupt if ohci_state
+ * was OHCI_RH_HALTED.
+ */
+ ohci_resume(hcd, !ohci_at91->wakeup);
return 0;
}
--
2.25.1
next reply other threads:[~2023-06-25 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 16:15 Guiting Shen [this message]
2023-06-25 20:04 ` [PATCH v2] usb: ohci-at91: Fix the unhandle interrupt when resume Alan Stern
2023-06-26 2:28 ` Guiting Shen
2023-06-26 14:16 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230625161553.11073-1-aarongt.shen@gmail.com \
--to=aarongt.shen@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox