Re: [PATCH] usb: host: xhci: fix coverity checker CONSTANT_EXPRESSION_RESULT warning

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jul 05, 2023 at 06:57:43PM +0800, Li Jun wrote:
> CID 28889612: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
> result_independent_of_operands: urb->transfer_dma >> 16 >> 16 is 0
> regardless of the values of its operands. This occurs as an argument
> to a function call.

What does "CID BIGNUMBER" mean?

> So convert the dma address to be u64 when extract its upper 32 bits.
> 
> Signed-off-by: Li Jun <jun.li@nxp.com>

What commit id does this fix?


> ---
>  drivers/usb/host/xhci-ring.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 646ff125def5..847a1eadd17a 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -747,7 +747,7 @@ static int xhci_move_dequeue_past_td(struct xhci_hcd *xhci,
>  		trb_sct = SCT_FOR_TRB(SCT_PRI_TR);
>  	ret = queue_command(xhci, cmd,
>  		lower_32_bits(addr) | trb_sct | new_cycle,
> -		upper_32_bits(addr),
> +		upper_32_bits((u64) addr),

Is this really actually changing anything?

thanks,

greg k-h