From: Frank Li <Frank.Li@nxp.com>
To: frank.li@nxp.com
Cc: Thinh.Nguyen@synopsys.com, andriy.shevchenko@linux.intel.com,
gregkh@linuxfoundation.org, imx@lists.linux.dev,
jgilab@gmail.com, jun.li@nxp.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, peter.chen@kernel.org,
quic_eserrao@quicinc.com, quic_prashk@quicinc.com,
r-gunasekaran@ti.com, rogerq@kernel.org
Subject: [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to verify UDC capability
Date: Fri, 7 Jul 2023 19:00:14 -0400 [thread overview]
Message-ID: <20230707230015.494999-1-Frank.Li@nxp.com> (raw)
The legacy gadget driver omitted calling usb_gadget_check_config()
to ensure that the USB device controller (UDC) has adequate resources,
including sufficient endpoint numbers and types, to support the given
configuration.
Previously, usb_add_config() was solely invoked by the legacy gadget
driver. Adds the necessary usb_gadget_check_config() after the bind()
operation to fix the issue.
Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
Reported-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change from v1 to v2
- not change for this patch, just add new patch to fix multi-config case
drivers/usb/gadget/composite.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 403563c06477..cb0a4e2cdbb7 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -1029,6 +1029,10 @@ int usb_add_config(struct usb_composite_dev *cdev,
goto done;
status = bind(config);
+
+ if (status == 0)
+ status = usb_gadget_check_config(cdev->gadget);
+
if (status < 0) {
while (!list_empty(&config->functions)) {
struct usb_function *f;
--
2.34.1
next reply other threads:[~2023-07-07 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 23:00 Frank Li [this message]
2023-07-07 23:00 ` [PATCH v2 2/2] usb: cdns3: fix incorrect calculation of ep_buf_size when more than one config Frank Li
[not found] ` <f803653c-8967-b187-8339-fbec0cdeef25@web.de>
2023-07-09 8:06 ` Greg Kroah-Hartman
2023-07-10 3:38 ` Peter Chen
2023-07-10 11:14 ` Ravi Gunasekaran
2023-07-25 14:37 ` [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to verify UDC capability Frank Li
2023-07-25 15:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707230015.494999-1-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jgilab@gmail.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=quic_prashk@quicinc.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox