* [PATCH] Style error/warning fixes: replacing space with tabs
@ 2023-07-09 0:51 Prince Kumar Maurya
2023-07-10 9:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Prince Kumar Maurya @ 2023-07-09 0:51 UTC (permalink / raw)
To: gregkh, raychi, skhan
Cc: Prince Kumar Maurya, linux-usb, linux-kernel-mentees
Style fixes for warning found using checkpatch.pl script
Signed-off-by: Prince Kumar Maurya <princekumarmaurya06@gmail.com>
---
drivers/usb/core/hub.c | 58 +++++++++++++++++++++---------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index a739403a9e45..82a7b127a340 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1777,7 +1777,7 @@ static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
if (!usb_endpoint_is_int_in(&desc->endpoint[0].desc))
return false;
- return true;
+ return true;
}
static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
@@ -5854,37 +5854,37 @@ static void hub_event(struct work_struct *work)
}
static const struct usb_device_id hub_id_table[] = {
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
- | USB_DEVICE_ID_MATCH_PRODUCT
- | USB_DEVICE_ID_MATCH_INT_CLASS,
- .idVendor = USB_VENDOR_SMSC,
- .idProduct = USB_PRODUCT_USB5534B,
- .bInterfaceClass = USB_CLASS_HUB,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
- | USB_DEVICE_ID_MATCH_PRODUCT,
- .idVendor = USB_VENDOR_CYPRESS,
- .idProduct = USB_PRODUCT_CY7C65632,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ | USB_DEVICE_ID_MATCH_PRODUCT
+ | USB_DEVICE_ID_MATCH_INT_CLASS,
+ .idVendor = USB_VENDOR_SMSC,
+ .idProduct = USB_PRODUCT_USB5534B,
+ .bInterfaceClass = USB_CLASS_HUB,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ | USB_DEVICE_ID_MATCH_PRODUCT,
+ .idVendor = USB_VENDOR_CYPRESS,
+ .idProduct = USB_PRODUCT_CY7C65632,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_INT_CLASS,
- .idVendor = USB_VENDOR_GENESYS_LOGIC,
- .bInterfaceClass = USB_CLASS_HUB,
- .driver_info = HUB_QUIRK_CHECK_PORT_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ .idVendor = USB_VENDOR_GENESYS_LOGIC,
+ .bInterfaceClass = USB_CLASS_HUB,
+ .driver_info = HUB_QUIRK_CHECK_PORT_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_PRODUCT,
- .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
- .idProduct = USB_PRODUCT_TUSB8041_USB2,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
+ .idProduct = USB_PRODUCT_TUSB8041_USB2,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_PRODUCT,
- .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
- .idProduct = USB_PRODUCT_TUSB8041_USB3,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
- .bDeviceClass = USB_CLASS_HUB},
- { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,
- .bInterfaceClass = USB_CLASS_HUB},
+ .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
+ .idProduct = USB_PRODUCT_TUSB8041_USB3,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
+ .bDeviceClass = USB_CLASS_HUB},
+ { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,
+ .bInterfaceClass = USB_CLASS_HUB},
{ } /* Terminating entry */
};
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Style error/warning fixes: replacing space with tabs
2023-07-09 0:51 [PATCH] Style error/warning fixes: replacing space with tabs Prince Kumar Maurya
@ 2023-07-10 9:24 ` Krzysztof Kozlowski
2023-07-11 4:27 ` [PATCH] driver/usb: Fixing code style error/warning Prince Kumar Maurya
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-10 9:24 UTC (permalink / raw)
To: Prince Kumar Maurya, gregkh, raychi, skhan
Cc: linux-kernel-mentees, linux-usb
On 09/07/2023 02:51, Prince Kumar Maurya wrote:
> Style fixes for warning found using checkpatch.pl script
>
> Signed-off-by: Prince Kumar Maurya <princekumarmaurya06@gmail.com>
> ---
> drivers/usb/core/hub.c | 58 +++++++++++++++++++++---------------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index a739403a9e45..82a7b127a340 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1777,7 +1777,7 @@ static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
> if (!usb_endpoint_is_int_in(&desc->endpoint[0].desc))
> return false;
>
> - return true;
> + return true;
This does not look like correctly indented.
> }
>
> static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
> @@ -5854,37 +5854,37 @@ static void hub_event(struct work_struct *work)
> }
>
> static const struct usb_device_id hub_id_table[] = {
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> - | USB_DEVICE_ID_MATCH_PRODUCT
> - | USB_DEVICE_ID_MATCH_INT_CLASS,
> - .idVendor = USB_VENDOR_SMSC,
> - .idProduct = USB_PRODUCT_USB5534B,
> - .bInterfaceClass = USB_CLASS_HUB,
> - .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> - | USB_DEVICE_ID_MATCH_PRODUCT,
> - .idVendor = USB_VENDOR_CYPRESS,
> - .idProduct = USB_PRODUCT_CY7C65632,
> - .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + | USB_DEVICE_ID_MATCH_PRODUCT
> + | USB_DEVICE_ID_MATCH_INT_CLASS,
> + .idVendor = USB_VENDOR_SMSC,
Spaces after the tab. Are you sure this does not cause checkpatch
--strict errors?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] driver/usb: Fixing code style error/warning
2023-07-10 9:24 ` Krzysztof Kozlowski
@ 2023-07-11 4:27 ` Prince Kumar Maurya
2023-07-11 4:44 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Prince Kumar Maurya @ 2023-07-11 4:27 UTC (permalink / raw)
To: krzk, gregkh, raychi, skhan
Cc: linux-kernel-mentees, linux-usb, princekumarmaurya06
Update the patch and verified it with --strict flag.
Found no error/warning for this patch.
Signed-off-by: Prince Kumar Maurya <princekumarmaurya06@gmail.com>
---
drivers/usb/core/hub.c | 58 +++++++++++++++++++++---------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index a739403a9e45..27037affb746 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1777,7 +1777,7 @@ static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
if (!usb_endpoint_is_int_in(&desc->endpoint[0].desc))
return false;
- return true;
+ return true;
}
static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
@@ -5854,37 +5854,37 @@ static void hub_event(struct work_struct *work)
}
static const struct usb_device_id hub_id_table[] = {
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
- | USB_DEVICE_ID_MATCH_PRODUCT
- | USB_DEVICE_ID_MATCH_INT_CLASS,
- .idVendor = USB_VENDOR_SMSC,
- .idProduct = USB_PRODUCT_USB5534B,
- .bInterfaceClass = USB_CLASS_HUB,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
- | USB_DEVICE_ID_MATCH_PRODUCT,
- .idVendor = USB_VENDOR_CYPRESS,
- .idProduct = USB_PRODUCT_CY7C65632,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ | USB_DEVICE_ID_MATCH_PRODUCT
+ | USB_DEVICE_ID_MATCH_INT_CLASS,
+ .idVendor = USB_VENDOR_SMSC,
+ .idProduct = USB_PRODUCT_USB5534B,
+ .bInterfaceClass = USB_CLASS_HUB,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ | USB_DEVICE_ID_MATCH_PRODUCT,
+ .idVendor = USB_VENDOR_CYPRESS,
+ .idProduct = USB_PRODUCT_CY7C65632,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_INT_CLASS,
- .idVendor = USB_VENDOR_GENESYS_LOGIC,
- .bInterfaceClass = USB_CLASS_HUB,
- .driver_info = HUB_QUIRK_CHECK_PORT_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ .idVendor = USB_VENDOR_GENESYS_LOGIC,
+ .bInterfaceClass = USB_CLASS_HUB,
+ .driver_info = HUB_QUIRK_CHECK_PORT_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_PRODUCT,
- .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
- .idProduct = USB_PRODUCT_TUSB8041_USB2,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
+ .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
+ .idProduct = USB_PRODUCT_TUSB8041_USB2,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_PRODUCT,
- .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
- .idProduct = USB_PRODUCT_TUSB8041_USB3,
- .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
- { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
- .bDeviceClass = USB_CLASS_HUB},
- { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,
- .bInterfaceClass = USB_CLASS_HUB},
+ .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
+ .idProduct = USB_PRODUCT_TUSB8041_USB3,
+ .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
+ { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
+ .bDeviceClass = USB_CLASS_HUB},
+ { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,
+ .bInterfaceClass = USB_CLASS_HUB},
{ } /* Terminating entry */
};
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] driver/usb: Fixing code style error/warning
2023-07-11 4:27 ` [PATCH] driver/usb: Fixing code style error/warning Prince Kumar Maurya
@ 2023-07-11 4:44 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2023-07-11 4:44 UTC (permalink / raw)
To: Prince Kumar Maurya; +Cc: krzk, raychi, skhan, linux-kernel-mentees, linux-usb
On Mon, Jul 10, 2023 at 09:27:20PM -0700, Prince Kumar Maurya wrote:
> Update the patch and verified it with --strict flag.
> Found no error/warning for this patch.
>
> Signed-off-by: Prince Kumar Maurya <princekumarmaurya06@gmail.com>
> ---
> drivers/usb/core/hub.c | 58 +++++++++++++++++++++---------------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index a739403a9e45..27037affb746 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1777,7 +1777,7 @@ static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
> if (!usb_endpoint_is_int_in(&desc->endpoint[0].desc))
> return false;
>
> - return true;
> + return true;
> }
>
> static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
> @@ -5854,37 +5854,37 @@ static void hub_event(struct work_struct *work)
> }
>
> static const struct usb_device_id hub_id_table[] = {
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> - | USB_DEVICE_ID_MATCH_PRODUCT
> - | USB_DEVICE_ID_MATCH_INT_CLASS,
> - .idVendor = USB_VENDOR_SMSC,
> - .idProduct = USB_PRODUCT_USB5534B,
> - .bInterfaceClass = USB_CLASS_HUB,
> - .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> - | USB_DEVICE_ID_MATCH_PRODUCT,
> - .idVendor = USB_VENDOR_CYPRESS,
> - .idProduct = USB_PRODUCT_CY7C65632,
> - .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + | USB_DEVICE_ID_MATCH_PRODUCT
> + | USB_DEVICE_ID_MATCH_INT_CLASS,
> + .idVendor = USB_VENDOR_SMSC,
> + .idProduct = USB_PRODUCT_USB5534B,
> + .bInterfaceClass = USB_CLASS_HUB,
> + .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + | USB_DEVICE_ID_MATCH_PRODUCT,
> + .idVendor = USB_VENDOR_CYPRESS,
> + .idProduct = USB_PRODUCT_CY7C65632,
> + .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> | USB_DEVICE_ID_MATCH_INT_CLASS,
> - .idVendor = USB_VENDOR_GENESYS_LOGIC,
> - .bInterfaceClass = USB_CLASS_HUB,
> - .driver_info = HUB_QUIRK_CHECK_PORT_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + .idVendor = USB_VENDOR_GENESYS_LOGIC,
> + .bInterfaceClass = USB_CLASS_HUB,
> + .driver_info = HUB_QUIRK_CHECK_PORT_AUTOSUSPEND},
> + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> | USB_DEVICE_ID_MATCH_PRODUCT,
> - .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
> - .idProduct = USB_PRODUCT_TUSB8041_USB2,
> - .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> + .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
> + .idProduct = USB_PRODUCT_TUSB8041_USB2,
> + .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> | USB_DEVICE_ID_MATCH_PRODUCT,
> - .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
> - .idProduct = USB_PRODUCT_TUSB8041_USB3,
> - .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> - { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
> - .bDeviceClass = USB_CLASS_HUB},
> - { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,
> - .bInterfaceClass = USB_CLASS_HUB},
> + .idVendor = USB_VENDOR_TEXAS_INSTRUMENTS,
> + .idProduct = USB_PRODUCT_TUSB8041_USB3,
> + .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> + { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
> + .bDeviceClass = USB_CLASS_HUB},
> + { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,
> + .bInterfaceClass = USB_CLASS_HUB},
> { } /* Terminating entry */
> };
>
> --
> 2.40.1
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-11 4:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-09 0:51 [PATCH] Style error/warning fixes: replacing space with tabs Prince Kumar Maurya
2023-07-10 9:24 ` Krzysztof Kozlowski
2023-07-11 4:27 ` [PATCH] driver/usb: Fixing code style error/warning Prince Kumar Maurya
2023-07-11 4:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).