linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: hiddev: Modify Format
       [not found] <20230716040716.25980-1-zhanglibing@cdjrlc.com>
@ 2023-07-16  4:11 ` wuyonggang001
  2023-07-16  5:39   ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: wuyonggang001 @ 2023-07-16  4:11 UTC (permalink / raw)
  To: jikos, benjamin.tissoires; +Cc: linux-usb, linux-input, linux-kernel

Fix the following checkpatch error(s):

ERROR: "inode * inode" should be "inode *inode"
ERROR: "file * file" should be "file *file"

Signed-off-by: Libing Zhang <zhanglibing@cdjrlc.com>
---
  drivers/hid/usbhid/hiddev.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 59cf3ddfdf78..581dc33197d0 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, 
int on)
  /*
   * release file op
   */
-static int hiddev_release(struct inode * inode, struct file * file)
+static int hiddev_release(struct inode *inode, struct file *file)
  {
      struct hiddev_list *list = file->private_data;
      unsigned long flags;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: hiddev: Modify Format
  2023-07-16  4:11 ` [PATCH] HID: hiddev: Modify Format wuyonggang001
@ 2023-07-16  5:39   ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-07-16  5:39 UTC (permalink / raw)
  To: wuyonggang001
  Cc: jikos, benjamin.tissoires, linux-usb, linux-input, linux-kernel

On Sun, Jul 16, 2023 at 12:11:11PM +0800, wuyonggang001@208suo.com wrote:
> Fix the following checkpatch error(s):
> 
> ERROR: "inode * inode" should be "inode *inode"
> ERROR: "file * file" should be "file *file"
> 
> Signed-off-by: Libing Zhang <zhanglibing@cdjrlc.com>
> ---
>  drivers/hid/usbhid/hiddev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 59cf3ddfdf78..581dc33197d0 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, int
> on)
>  /*
>   * release file op
>   */
> -static int hiddev_release(struct inode * inode, struct file * file)
> +static int hiddev_release(struct inode *inode, struct file *file)
>  {
>      struct hiddev_list *list = file->private_data;
>      unsigned long flags;

This patch is corrupted and can not be applied.

Please try working on drivers/staging/* files instead first, to give you
a chance to figure out how to do kernel development, before attempting
checkpatch changes on subsystems that might not want them.

good luck!

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-16  5:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230716040716.25980-1-zhanglibing@cdjrlc.com>
2023-07-16  4:11 ` [PATCH] HID: hiddev: Modify Format wuyonggang001
2023-07-16  5:39   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).