From: Greg KH <gregkh@linuxfoundation.org>
To: Utkarsh Patel <utkarsh.h.patel@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
heikki.krogerus@linux.intel.com, pmalani@chromium.org,
bleung@chromium.org
Subject: Re: [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type
Date: Tue, 18 Jul 2023 15:29:28 +0200 [thread overview]
Message-ID: <2023071800-roaming-automated-5404@gregkh> (raw)
In-Reply-To: <20230718024703.1013367-3-utkarsh.h.patel@intel.com>
On Mon, Jul 17, 2023 at 07:47:03PM -0700, Utkarsh Patel wrote:
> Cable type such as active and retimer received as a part of Thunderbolt3
> or Thunderbolt4 cable discover mode VDO needs to be configured in the
> thunderbolt alternate mode.
>
> Configuring the register bits for this cable type is changed with Intel
> Meteor Lake platform. BIT2 for Retimer/Redriver cable and BIT22 for
> Active/Passive cable.
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
> ---
> Changes in v4:
> - No changes.
>
> Changes in v3:
> - No changes.
>
> Changes in v2:
> - No changes.
> ---
> ---
> drivers/usb/typec/mux/intel_pmc_mux.c | 28 +++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
Why the 2 --- lines?
And why are you not cc:ing all the proper people (i.e. the person that
can actually apply this...)?
confused,
greg k-h
next prev parent reply other threads:[~2023-07-18 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 2:47 [PATCH v4 0/2]Add support to configure active retimer cable Utkarsh Patel
2023-07-18 2:47 ` [PATCH v4 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type Utkarsh Patel
2023-07-31 3:52 ` Patel, Utkarsh H
2023-08-15 22:09 ` Patel, Utkarsh H
2023-08-18 17:01 ` Prashant Malani
2023-08-21 17:18 ` Patel, Utkarsh H
2023-08-21 23:30 ` Prashant Malani
2023-08-22 21:21 ` Patel, Utkarsh H
2023-08-23 15:35 ` Prashant Malani
2023-08-25 21:04 ` Patel, Utkarsh H
2023-08-26 7:40 ` Greg KH
2023-08-26 9:12 ` Greg KH
2023-07-18 2:47 ` [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type Utkarsh Patel
2023-07-18 13:29 ` Greg KH [this message]
2023-07-19 20:46 ` Patel, Utkarsh H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071800-roaming-automated-5404@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bleung@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox