* [PATCH v1] usb: cdns3: Add PHY mode switch to usb2 PHY
@ 2023-07-21 9:59 Minda Chen
2023-07-22 7:58 ` Roger Quadros
0 siblings, 1 reply; 2+ messages in thread
From: Minda Chen @ 2023-07-21 9:59 UTC (permalink / raw)
To: Pawel Laszczak, Greg Kroah-Hartman, Peter Chen, Roger Quadros
Cc: linux-kernel, linux-usb, Minda Chen
cdns3 just set PHY mode switch for USB3.0 PHY.
If USB 2.0 PHY contains PHY mode switch setting,
USB 2.0 PHY mode function can't be called.
So add PHY mode switch function for USB 2.0 PHY.
Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
---
drivers/usb/cdns3/drd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
index d00ff98dffab..04b6d12f2b9a 100644
--- a/drivers/usb/cdns3/drd.c
+++ b/drivers/usb/cdns3/drd.c
@@ -196,6 +196,7 @@ int cdns_drd_host_on(struct cdns *cdns)
if (ret)
dev_err(cdns->dev, "timeout waiting for xhci_ready\n");
+ phy_set_mode(cdns->usb2_phy, PHY_MODE_USB_HOST);
phy_set_mode(cdns->usb3_phy, PHY_MODE_USB_HOST);
return ret;
}
@@ -216,6 +217,7 @@ void cdns_drd_host_off(struct cdns *cdns)
readl_poll_timeout_atomic(&cdns->otg_regs->state, val,
!(val & OTGSTATE_HOST_STATE_MASK),
1, 2000000);
+ phy_set_mode(cdns->usb2_phy, PHY_MODE_INVALID);
phy_set_mode(cdns->usb3_phy, PHY_MODE_INVALID);
}
@@ -248,6 +250,7 @@ int cdns_drd_gadget_on(struct cdns *cdns)
return ret;
}
+ phy_set_mode(cdns->usb2_phy, PHY_MODE_USB_DEVICE);
phy_set_mode(cdns->usb3_phy, PHY_MODE_USB_DEVICE);
return 0;
}
@@ -273,6 +276,7 @@ void cdns_drd_gadget_off(struct cdns *cdns)
readl_poll_timeout_atomic(&cdns->otg_regs->state, val,
!(val & OTGSTATE_DEV_STATE_MASK),
1, 2000000);
+ phy_set_mode(cdns->usb2_phy, PHY_MODE_INVALID);
phy_set_mode(cdns->usb3_phy, PHY_MODE_INVALID);
}
EXPORT_SYMBOL_GPL(cdns_drd_gadget_off);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] usb: cdns3: Add PHY mode switch to usb2 PHY
2023-07-21 9:59 [PATCH v1] usb: cdns3: Add PHY mode switch to usb2 PHY Minda Chen
@ 2023-07-22 7:58 ` Roger Quadros
0 siblings, 0 replies; 2+ messages in thread
From: Roger Quadros @ 2023-07-22 7:58 UTC (permalink / raw)
To: Minda Chen, Pawel Laszczak, Greg Kroah-Hartman, Peter Chen
Cc: linux-kernel, linux-usb
On 21/07/2023 12:59, Minda Chen wrote:
> cdns3 just set PHY mode switch for USB3.0 PHY.
> If USB 2.0 PHY contains PHY mode switch setting,
> USB 2.0 PHY mode function can't be called.
> So add PHY mode switch function for USB 2.0 PHY.
>
> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-22 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-21 9:59 [PATCH v1] usb: cdns3: Add PHY mode switch to usb2 PHY Minda Chen
2023-07-22 7:58 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).