From: Greg KH <gregkh@linuxfoundation.org>
To: Elson Serrao <quic_eserrao@quicinc.com>
Cc: Surong Pang <surong.pang@unisoc.com>,
Thinh.Nguyen@synopsys.com, felipe.balbi@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
rogerq@kernel.org, Orson.Zhai@unisoc.com,
Chunyan.Zhang@unisoc.com, Zhiyong.liu@unisoc.com,
Surong.Pang@gmail.com
Subject: Re: [PATCH V2] usb: dwc3: gadget: Let pm runtime get/put paired
Date: Tue, 1 Aug 2023 06:43:58 +0200 [thread overview]
Message-ID: <2023080128-bubble-frosty-92c8@gregkh> (raw)
In-Reply-To: <e8d9652f-3b81-319a-7ca6-9b656eac6f40@quicinc.com>
On Mon, Jul 31, 2023 at 06:33:04PM -0700, Elson Serrao wrote:
>
>
> On 7/31/2023 6:15 PM, Surong Pang wrote:
> > Pm_runtime_get is called when setting pending_events to true.
> > Pm_runtime_put is needed for pairing with pm_runtime_get.
> >
> > Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> > Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> >
> > ---
> > V2: add Fixes tag, fix Fixes tag
> > ---
> > drivers/usb/dwc3/gadget.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> > index 5fd067151fbf..9c835c5f9928 100644
> > --- a/drivers/usb/dwc3/gadget.c
> > +++ b/drivers/usb/dwc3/gadget.c
> > @@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
> > dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
> > dwc->pending_events = false;
> > enable_irq(dwc->irq_gadget);
> > + pm_runtime_put(dwc->dev);
> > }
> > }
>
> I am already handling this change as part of below series. Will be uploading
> a separate patch based on the feedback from Roger.
>
> https://lore.kernel.org/all/be57511d-2005-a1f5-d5a5-809e71029aec@quicinc.com/
But this should be fixed now, and properly backported to stable kernels.
There's no need to wait for a different patch series if this one is
correct, right?
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-01 4:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 1:15 [PATCH V2] usb: dwc3: gadget: Let pm runtime get/put paired Surong Pang
2023-08-01 1:33 ` Elson Serrao
2023-08-01 4:43 ` Greg KH [this message]
2023-08-01 19:41 ` Elson Serrao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080128-bubble-frosty-92c8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Chunyan.Zhang@unisoc.com \
--cc=Orson.Zhai@unisoc.com \
--cc=Surong.Pang@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=Zhiyong.liu@unisoc.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=rogerq@kernel.org \
--cc=surong.pang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox