From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9580DC0015E for ; Tue, 1 Aug 2023 07:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231871AbjHAHfG (ORCPT ); Tue, 1 Aug 2023 03:35:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231777AbjHAHfE (ORCPT ); Tue, 1 Aug 2023 03:35:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C4B31BC8; Tue, 1 Aug 2023 00:35:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C265614B0; Tue, 1 Aug 2023 07:35:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90DEAC433C7; Tue, 1 Aug 2023 07:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690875301; bh=nDYOW8cnkgStxoV8umgfFMfJVIByEnVT4YWAkNqEMRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yd3DVh+SKvwX2t6iV31hhZGku6kDP5Yua0oqViHooDkKT1/yKCbxG8TgWFEG8ckYl dXBIBObQIhBPBbSYLmfipN2n5JiwRwpE6kGBkaTbJtYSb9E8j0O1vDOJl/bWzHGsDx kxP0n5QLsdFm2JWhxUM3WX4fECIh6TIebTFxZzvU= Date: Tue, 1 Aug 2023 09:34:59 +0200 From: Greg KH To: chengdong zhou Cc: dan.scally@ideasonboard.com, laurent.pinchart@ideasonboard.com, m.grzeschik@pengutronix.de, john@keeping.me.uk, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: gadget: Fix the function name error in sourcesink/loopback. Message-ID: <2023080152-bakeshop-shanty-2033@gregkh> References: <20230801045449.156348-1-zhouscd@gmail.com> <2023080159-uncorrupt-chamber-7de0@gregkh> <2023080108-resilient-citation-9a34@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Aug 01, 2023 at 03:27:04PM +0800, chengdong zhou wrote: > Thank you for your patient response. > > On Tue, Aug 1, 2023 at 2:23 PM Greg KH wrote: > > > > > > Please document this in the changelog text. > > But I can't find the changelog text anywhere. That is what you are writing here for the commit. Please read the kernel documentation for how to submit a patch, it will explain this. > > But you changed the name: > > > > > > > - ss->function.name = "source/sink"; > > > > > + ss->function.name = "sourcesink"; > > > > isn't that visable to userspace? > > Yes, I removed the "/". Because the macro definition > DECLARE_USB_FUNCTION_INIT does not support "/". > Should I stick with the original "SourceSink"? I think using the > Linux-style "sourcesink" is better. By the way, due to the current > bug, no one should be able to use "source/sink" in userspace. But doesn't the '/' mean that you have a subdirectory here? What did userspace look like before this, and what does it look like now? thanks, greg k-h