From: Ruan Jinjie <ruanjinjie@huawei.com>
To: <peter.chen@kernel.org>, <gregkh@linuxfoundation.org>,
<leoyang.li@nxp.com>, <b-liu@ti.com>,
<valentina.manea.m@gmail.com>, <shuah@kernel.org>,
<i@zenithal.me>, <stern@rowland.harvard.edu>,
<u.kleine-koenig@pengutronix.de>, <aaro.koskinen@iki.fi>,
<void0red@gmail.com>, <linux-usb@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH -next 2/5] USB: misc: Remove unnecessary NULL values
Date: Fri, 4 Aug 2023 17:32:50 +0800 [thread overview]
Message-ID: <20230804093253.91647-3-ruanjinjie@huawei.com> (raw)
In-Reply-To: <20230804093253.91647-1-ruanjinjie@huawei.com>
The NULL initialization of the pointers assigned by kzalloc() first is
not necessary, because if the kzalloc() failed, the pointers will be
assigned NULL, otherwise it works as usual. so remove it.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/usb/misc/cypress_cy7c63.c | 2 +-
drivers/usb/misc/cytherm.c | 2 +-
drivers/usb/misc/usbsevseg.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/cypress_cy7c63.c b/drivers/usb/misc/cypress_cy7c63.c
index 14faec51d7a5..cecd7693b741 100644
--- a/drivers/usb/misc/cypress_cy7c63.c
+++ b/drivers/usb/misc/cypress_cy7c63.c
@@ -203,7 +203,7 @@ ATTRIBUTE_GROUPS(cypress);
static int cypress_probe(struct usb_interface *interface,
const struct usb_device_id *id)
{
- struct cypress *dev = NULL;
+ struct cypress *dev;
int retval = -ENOMEM;
/* allocate memory for our device state and initialize it */
diff --git a/drivers/usb/misc/cytherm.c b/drivers/usb/misc/cytherm.c
index 3e3802aaefa3..918833b471ea 100644
--- a/drivers/usb/misc/cytherm.c
+++ b/drivers/usb/misc/cytherm.c
@@ -304,7 +304,7 @@ static int cytherm_probe(struct usb_interface *interface,
const struct usb_device_id *id)
{
struct usb_device *udev = interface_to_usbdev(interface);
- struct usb_cytherm *dev = NULL;
+ struct usb_cytherm *dev;
int retval = -ENOMEM;
dev = kzalloc (sizeof(struct usb_cytherm), GFP_KERNEL);
diff --git a/drivers/usb/misc/usbsevseg.c b/drivers/usb/misc/usbsevseg.c
index c3114d9bd128..546deff754ba 100644
--- a/drivers/usb/misc/usbsevseg.c
+++ b/drivers/usb/misc/usbsevseg.c
@@ -305,7 +305,7 @@ static int sevseg_probe(struct usb_interface *interface,
const struct usb_device_id *id)
{
struct usb_device *udev = interface_to_usbdev(interface);
- struct usb_sevsegdev *mydev = NULL;
+ struct usb_sevsegdev *mydev;
int rc = -ENOMEM;
mydev = kzalloc(sizeof(struct usb_sevsegdev), GFP_KERNEL);
--
2.34.1
next prev parent reply other threads:[~2023-08-04 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:32 [PATCH -next 0/5] usb: Remove many unnecessary NULL values Ruan Jinjie
2023-08-04 9:32 ` [PATCH -next 1/5] usb: gadget: udc: Remove " Ruan Jinjie
2023-08-04 9:32 ` Ruan Jinjie [this message]
2023-08-04 9:32 ` [PATCH -next 3/5] usb: chipidea: udc: Remove an unnecessary NULL value Ruan Jinjie
2023-08-04 9:32 ` [PATCH -next 4/5] usb: musb: " Ruan Jinjie
2023-08-04 9:32 ` [PATCH -next 5/5] USB: usbip: " Ruan Jinjie
2023-08-04 20:09 ` shuah
2023-08-05 2:46 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804093253.91647-3-ruanjinjie@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=aaro.koskinen@iki.fi \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=leoyang.li@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peter.chen@kernel.org \
--cc=shuah@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=u.kleine-koenig@pengutronix.de \
--cc=valentina.manea.m@gmail.com \
--cc=void0red@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox