From: Greg KH <gregkh@linuxfoundation.org>
To: Saranya Gopal <saranya.gopal@intel.com>
Cc: linux-usb@vger.kernel.org, heikki.krogerus@linux.intel.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rajaram Regupathy <rajaram.regupathy@intel.com>
Subject: Re: [PATCH] usb: typec: ucsi: Add debugfs for ucsi commands
Date: Fri, 4 Aug 2023 14:00:54 +0200 [thread overview]
Message-ID: <2023080414-carnation-driven-ec73@gregkh> (raw)
In-Reply-To: <20230804115336.399801-1-saranya.gopal@intel.com>
On Fri, Aug 04, 2023 at 05:23:36PM +0530, Saranya Gopal wrote:
> --- /dev/null
> +++ b/drivers/usb/typec/ucsi/debugfs.h
No need for a full .h file for this, why not put the 2 function
prototypes in the normal uscsi file?
> @@ -0,0 +1,47 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * UCSI debugfs interface
> + *
> + * Copyright (C) 2023 Intel Corporation
> + *
> + * Authors: Rajaram Regupathy <rajaram.regupathy@intel.com>
> + * Gopal Saranya <saranya.gopal@intel.com>
> + */
> +
> +#ifndef __LINUX_UCSI_DEBUGFS_H
> +#define __LINUX_UCSI_DEBUGFS_H
> +
> +#include <linux/types.h>
> +
> +struct ucsi;
> +struct dentry;
> +
> +struct ucsi_debugfs_entry {
> + u64 command;
> + struct ucsi_data {
> + u64 low;
> + u64 high;
> + } response;
> + u32 status;
> + struct dentry *dentry;
> +};
This can go into the .c file, right?
thanks,
greg k-h
prev parent reply other threads:[~2023-08-04 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 11:53 [PATCH] usb: typec: ucsi: Add debugfs for ucsi commands Saranya Gopal
2023-08-04 11:59 ` Greg KH
2023-08-04 12:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080414-carnation-driven-ec73@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=rajaram.regupathy@intel.com \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox