From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-renesas-soc@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 2/4] usb: typec: tcpci_rt1711h: Convert enum->pointer for data in the match tables
Date: Wed, 23 Aug 2023 17:20:52 +0200 [thread overview]
Message-ID: <2023082354-pledge-salary-0d6f@gregkh> (raw)
In-Reply-To: <CAMuHMdWW_3Wmq-XFd6HCmHhE2RScWMEUas7O7XuSniXPb3k4Dg@mail.gmail.com>
On Wed, Aug 23, 2023 at 05:10:22PM +0200, Geert Uytterhoeven wrote:
> Hi Andi,
>
> On Wed, Aug 23, 2023 at 4:49 PM Andi Shyti <andi.shyti@kernel.org> wrote:
> > I would rather prefer to store pointers in u64 variables rather
> > than integers in a pointer.
>
> "u64" is overkill, as it is too large on 32-bit platforms.
> "uintptr_t" (or ("unsigned long") in legacy code) is the correct integer type.
"unsigned long" in kernel code is the guaranteed size of a pointer.
unitptr_t is for userspace code, it should not be used here in the
kernel as that's the wrong variable namespace.
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-23 15:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 18:43 [PATCH 0/4] onvert enum->pointer for data in the rt1711h match tables Biju Das
2023-08-20 18:43 ` [PATCH 1/4] usb: typec: tcpci_rt1711h: Make similar OF and ID table Biju Das
2023-08-20 18:44 ` [PATCH 2/4] usb: typec: tcpci_rt1711h: Convert enum->pointer for data in the match tables Biju Das
2023-08-21 13:04 ` Andy Shevchenko
2023-08-21 13:27 ` Geert Uytterhoeven
2023-08-21 15:24 ` Andy Shevchenko
2023-08-21 15:40 ` Geert Uytterhoeven
2023-08-21 16:05 ` Guenter Roeck
2023-08-21 17:08 ` Andy Shevchenko
2023-08-22 7:21 ` Geert Uytterhoeven
2023-08-22 11:44 ` Andy Shevchenko
2023-08-22 12:00 ` Geert Uytterhoeven
2023-08-22 12:08 ` Andy Shevchenko
2023-08-22 12:51 ` Biju Das
2023-08-22 13:23 ` Andy Shevchenko
2023-08-23 14:49 ` Andi Shyti
2023-08-23 15:10 ` Geert Uytterhoeven
2023-08-23 15:20 ` Greg Kroah-Hartman [this message]
2023-08-23 15:36 ` Dmitry Torokhov
2023-08-21 16:45 ` Biju Das
2023-08-20 18:44 ` [PATCH 3/4] usb: typec: tcpci_rt1711h: Add rxdz_sel variable to struct rt1711h_chip_info Biju Das
2023-08-21 13:06 ` Andy Shevchenko
2023-08-21 13:33 ` Geert Uytterhoeven
2023-08-21 15:26 ` Andy Shevchenko
2023-08-20 18:44 ` [PATCH 4/4] usb: typec: tcpci_rt1711h: Add enable_pd30_extended_message feature bit " Biju Das
2023-08-21 13:08 ` Andy Shevchenko
2023-08-21 14:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082354-pledge-salary-0d6f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox