From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF369C83F16 for ; Sat, 26 Aug 2023 09:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbjHZJMs (ORCPT ); Sat, 26 Aug 2023 05:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232191AbjHZJMg (ORCPT ); Sat, 26 Aug 2023 05:12:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64AAFE6F; Sat, 26 Aug 2023 02:12:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF66160B71; Sat, 26 Aug 2023 09:12:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E666AC433C7; Sat, 26 Aug 2023 09:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693041152; bh=9SNaW1VlJaqI3jpJ0iaurhE1RUXXKa3FEFwmHL37uDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GQ29Eo9rUax2TdRjZ2eGctC9wse1Qthlrq6g5/bfksyhwRA7d7lId81ojdKwE6PFd yCJN8aB8wRgQpdaPE2rPVm35ogPe2xtuk9UMS5uGBFArJENL+JH17jzUfoTyKcLjkU U5sGLnyn5aTz1z3E9uAybEaF4qPPfWQocexcAW/k= Date: Sat, 26 Aug 2023 11:12:29 +0200 From: Greg KH To: "Patel, Utkarsh H" Cc: Prashant Malani , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "heikki.krogerus@linux.intel.com" , "bleung@chromium.org" Subject: Re: [PATCH v4 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type Message-ID: <2023082612-vintage-spilt-1b74@gregkh> References: <20230718024703.1013367-1-utkarsh.h.patel@intel.com> <20230718024703.1013367-2-utkarsh.h.patel@intel.com> <2023082600-moisture-corroding-c1e9@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023082600-moisture-corroding-c1e9@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Aug 26, 2023 at 09:40:20AM +0200, Greg KH wrote: > On Fri, Aug 25, 2023 at 09:04:29PM +0000, Patel, Utkarsh H wrote: > > Hi Greg, > > > > > > > > > > > > > > We are only calling it once depending upon which mode we enter TBT > > > > > > Alt or > > > > > USB4. > > > > > > > > > > There should only be 1 "call site" and that should be sufficient to > > > > > grab the VDO from the framework for all circumstances. Whether the > > > > > other invocation doesn't get called under certain circumstances isn't as > > > relevant. > > > > > > > > Are you suggesting something like this? > > > > > > > > static int cros_typec_configure_mux(struct cros_typec_data *typec, int > > > port_num,)... > > > > > > > > if (port->mux_flags & USB_PD_MUX_USB4_ENABLED || > > > > port->mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED) > > > > cable_tbt_vdo = cros_typec_get_cable_vdo(port, > > > USB_TYPEC_TBT_SID); > > > > > > My apologies, I misread the patch. I think this looks good. > > > > > > Acked-by: Prashant Malani > > > > Could you please add this patch to usb-next. > > Ugh, it's late in the cycle, but this has been around for a while, let > me go see... Looks like patch 2/2 was already in my tree, so I've queued up this one now as well. thanks, greg k-h