Linux USB
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: DWC3-Gadget: Flickering with ISOC Streaming (UVC) while multiplier set on Superspeed
Date: Fri, 1 Sep 2023 01:35:16 +0000	[thread overview]
Message-ID: <20230901013118.iqpegkklfswdkoqc@synopsys.com> (raw)
In-Reply-To: <20230831221242.GC20651@pengutronix.de>

Hi Michael,

On Fri, Sep 01, 2023, Michael Grzeschik wrote:
> Hi Thinh!
> 
> I just stumbled over a similar issue we already solved for the High
> Speed Case when streaming ISOC packages and using a multiplier higher
> then one. Last time we saw some bad frame artefacts when using the
> higher multiplier value. The Frames were distorted due to truncated
> transfers.
> 
> Since the last case we have patch
> 
> 8affe37c525d ("usb: dwc3: gadget: fix high speed multiplier setting")
> 
> that fixes the calculation of the mult PCM1 parameter when using high
> speed transfers. After that no truncations were reported again.
> 
> However I came across a similar issue which is just a little less easy
> to trigger and only occurs with Superspeed. Now, while the memory
> bandwidth of the machine runs on higher load, the UVC frames are
> similarly distorted when we use a multiplier higher then one.
> 
> I looked over the implications the multiplier has on the Superspeed case
> in the dwc3 gadget driver, but could only find some TXFIFO adjustments
> and no other extra bits e.g. in the transfer descriptors. Do you have
> some pointers how the multiplier parameter of the endpoint is used in
> hardware?
> 

As you already know, PCM1 is only for highspeed not Superspeed. What
failure did the dwc3 driver reported? Missed isoc? What's the request
transfer size?

Perhaps you can capture some tracepoints of the problem?

Thanks,
Thinh

  reply	other threads:[~2023-09-01  1:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 22:12 DWC3-Gadget: Flickering with ISOC Streaming (UVC) while multiplier set on Superspeed Michael Grzeschik
2023-09-01  1:35 ` Thinh Nguyen [this message]
2023-09-03 22:41   ` Michael Grzeschik
2023-09-04  0:42     ` Michael Grzeschik
2023-09-06  0:44       ` Thinh Nguyen
2023-09-06  6:40         ` Michael Grzeschik
2023-09-06  0:41     ` Thinh Nguyen
2023-09-06  7:18       ` Michael Grzeschik
2023-09-06 23:05         ` Thinh Nguyen
2023-09-06 23:09           ` Thinh Nguyen
2023-09-07 21:00             ` Michael Grzeschik
2023-09-07 23:33               ` Thinh Nguyen
2023-10-30 12:18                 ` Michael Grzeschik
2023-10-31 23:18                   ` Thinh Nguyen
2023-11-09 23:33                     ` [PATCH] usb: gadget: uvc: reduce the request size to increase the throughput Michael Grzeschik
2023-11-10  2:16                       ` Thinh Nguyen
2023-11-10 22:42                         ` Thinh Nguyen
2023-11-13  8:43                         ` Michael Grzeschik
2023-11-17  2:39                           ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230901013118.iqpegkklfswdkoqc@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgr@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox