From: Wesley Cheng <quic_wcheng@quicinc.com>
To: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<srinivas.kandagatla@linaro.org>, <bgoswami@quicinc.com>,
<Thinh.Nguyen@synopsys.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<alsa-devel@alsa-project.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>
Subject: [PATCH v6 33/33] ASoC: usb: Rediscover USB SND devices on USB port add
Date: Fri, 15 Sep 2023 17:10:26 -0700 [thread overview]
Message-ID: <20230916001026.315-34-quic_wcheng@quicinc.com> (raw)
In-Reply-To: <20230916001026.315-1-quic_wcheng@quicinc.com>
In case the USB backend device has not been initialized/probed, USB SND
device connections can still occur. When the USB backend is eventually
made available, previous USB SND device connections are not communicated to
the USB backend. Call snd_usb_rediscover_devices() to generate the connect
callbacks for all USB SND devices connected. This will allow for the USB
backend to be updated with the current set of devices available.
The chip array entries are all populated and removed while under the
register_mutex, so going over potential race conditions:
Thread#1:
q6usb_component_probe()
--> snd_soc_usb_add_port()
--> snd_usb_rediscover_devices()
--> mutex_lock(register_mutex)
Thread#2
--> usb_audio_disconnect()
--> mutex_lock(register_mutex)
So either thread#1 or thread#2 will complete first. If
Thread#1 completes before thread#2:
SOC USB will notify DPCM backend of the device connection. Shortly
after, once thread#2 runs, we will get a disconnect event for the
connected device.
Thread#2 completes before thread#1:
Then during snd_usb_rediscover_devices() it won't notify of any
connection for that particular chip index.
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
sound/soc/soc-usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/soc-usb.c b/sound/soc/soc-usb.c
index 619f9bfd6999..7df7f93cf5a2 100644
--- a/sound/soc/soc-usb.c
+++ b/sound/soc/soc-usb.c
@@ -115,6 +115,8 @@ struct snd_soc_usb *snd_soc_usb_add_port(struct device *dev, void *priv,
list_add_tail(&usb->list, &usb_ctx_list);
mutex_unlock(&ctx_mutex);
+ snd_usb_rediscover_devices();
+
return usb;
}
EXPORT_SYMBOL_GPL(snd_soc_usb_add_port);
prev parent reply other threads:[~2023-09-16 0:11 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 0:09 [PATCH v6 00/33] Introduce QC USB SND audio offloading support Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 01/33] xhci: add support to allocate several interrupters Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 02/33] xhci: add helper to stop endpoint and wait for completion Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 03/33] xhci: sideband: add initial api to register a sideband entity Wesley Cheng
2023-09-16 9:02 ` Hillf Danton
2023-09-19 21:26 ` Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 04/33] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 05/33] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 06/33] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 07/33] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 08/33] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 09/33] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 10/33] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 Wesley Cheng
2023-09-16 0:34 ` Konrad Dybcio
2023-09-16 1:16 ` Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 11/33] ALSA: usb-audio: Introduce USB SND platform op callbacks Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 12/33] ALSA: usb-audio: Export USB SND APIs for modules Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 13/33] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Wesley Cheng
2023-09-16 0:35 ` Konrad Dybcio
2023-09-16 0:43 ` Wesley Cheng
2023-09-18 20:19 ` Rob Herring
2023-09-19 0:23 ` Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 14/33] dt-bindings: usb: xhci: Add num-hc-interrupters definition Wesley Cheng
2023-09-18 20:19 ` Rob Herring
2023-09-16 0:10 ` [PATCH v6 15/33] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 16/33] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 17/33] ALSA: usb-audio: qcom: Add USB QMI definitions Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 18/33] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 19/33] ALSA: usb-audio: Check for support for requested audio format Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 20/33] ASoC: usb: Add PCM format check API for USB backend Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 21/33] ASoC: qcom: qdsp6: Ensure PCM format is supported by USB audio device Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 22/33] ALSA: usb-audio: Prevent starting of audio stream if in use Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 23/33] ASoC: dt-bindings: Add Q6USB backend Wesley Cheng
2023-09-16 0:37 ` Konrad Dybcio
2023-09-16 0:46 ` Wesley Cheng
2023-09-16 2:36 ` Rob Herring
2023-09-16 0:10 ` [PATCH v6 24/33] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2023-09-16 2:36 ` Rob Herring
2023-09-16 0:10 ` [PATCH v6 25/33] ASoC: qcom: qdsp6: q6afe: Split USB AFE dev_token param into separate API Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 26/33] ALSA: usb-audio: qcom: Populate PCM and USB chip information Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 27/33] ASoC: qcom: qdsp6: Add support to track available USB PCM devices Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 28/33] ASoC: qcom: qdsp6: Add SND kcontrol to select offload device Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 29/33] ASoC: qcom: qdsp6: Add SND kcontrol for fetching offload status Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 30/33] ASoC: qcom: qdsp6: Add headphone jack for offload connection status Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 31/33] ALSA: usb-audio: qcom: Use card and PCM index from QMI request Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 32/33] ALSA: usb-audio: Allow for rediscovery of connected USB SND devices Wesley Cheng
2023-09-16 0:10 ` Wesley Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916001026.315-34-quic_wcheng@quicinc.com \
--to=quic_wcheng@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox