From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 1/3] usb: gadget: add anonymous definition in some struct for trace purpose
Date: Sun, 17 Sep 2023 10:01:48 +0200 [thread overview]
Message-ID: <2023091712-cahoots-saturate-dc9f@gregkh> (raw)
In-Reply-To: <20230915052716.28540-2-quic_linyyuan@quicinc.com>
On Fri, Sep 15, 2023 at 01:27:14PM +0800, Linyu Yuan wrote:
> Some UDC trace event will save usb udc information, but it use one int
> size buffer to save one bit information of usb udc, it waste trace buffer.
How much waste exactly?
> Add anonymous union which have u32 members can be used by trace event
> during fast assign stage to save more entries with same trace ring buffer
> size.
Are you sure?
> Also add some trace event purpose macro in this file for all possiable
> use.
When you say "also" in a changelog, that means the change should be
split up into multiple patches.
> +/*-------------------------------------------------------------------------*/
> +/* trace only, data in __le32 format at trace event fast assign stage */
> +#define USB_GADGET_SG_SUPPORTED BIT(0)
<snip>
This will not work well at all, and is probably broken as-is, sorry,
please rethink all of this.
greg k-h
next prev parent reply other threads:[~2023-09-17 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 5:27 [PATCH v6 0/3] usb: gadget: reduce usb gadget trace event buffer usage Linyu Yuan
2023-09-15 5:27 ` [PATCH v6 1/3] usb: gadget: add anonymous definition in some struct for trace purpose Linyu Yuan
2023-09-17 8:01 ` Greg Kroah-Hartman [this message]
2023-09-15 5:27 ` [PATCH v6 2/3] usb: udc: trace: reduce buffer usage of trace event Linyu Yuan
2023-09-15 5:27 ` [PATCH v6 /3] usb: dwc3: " Linyu Yuan
2023-09-17 8:00 ` Greg Kroah-Hartman
2023-09-15 14:13 ` [PATCH v6 0/3] usb: gadget: reduce usb gadget trace event buffer usage Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091712-cahoots-saturate-dc9f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=quic_linyyuan@quicinc.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox