From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29AF107A7
	for <linux-usb@vger.kernel.org>; Mon, 25 Sep 2023 11:53:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29217C433C8;
	Mon, 25 Sep 2023 11:53:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1695642790;
	bh=YRhfpioOfX3S6JRC0rfosLAUExubXaO5w4Y65Hn0l3Y=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=a6+WVnlGezj+qtyUXIXhLe67qX3OJQ0fWbhw0S038ekCwzLpi1+NXHMKhdQ29V3dN
	 4167nqxFrnEgn32OxJsYLFgw3ZLa3EskOVouzXgoCTZ0bomEP9Ex3uKrO4HfONA0UC
	 2YikxQkceBk2dE0PiFOjpvUJKNUwPM34/92yujU5KTQOaJ9fGp6+1Sqn6cSKPP6rGj
	 gxvYjvqLBagF8b4uUSyjQ3zhTe98iCSg90cezYi/0onijme4eTgeDETP9OXjzfyjxm
	 cyHBdGCgOVJZARPG08VigXX7vVPioD7eZxY8BrLaZzYC1fy5J1a/RPGfWvf/oWWQ3K
	 T+XBUulr4kvmQ==
Date: Mon, 25 Sep 2023 19:53:00 +0800
From: Peter Chen <peter.chen@kernel.org>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: pawell@cadence.com, pavel@denx.de, rogerq@kernel.org,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: cdns3: Modify the return value of
 cdns_set_active () to void when CONFIG_PM_SLEEP is disabled
Message-ID: <20230925115300.GC2070044@nchen-desktop>
References: <20230920144045.2165758-1-xiaolei.wang@windriver.com>
Precedence: bulk
X-Mailing-List: linux-usb@vger.kernel.org
List-Id: <linux-usb.vger.kernel.org>
List-Subscribe: <mailto:linux-usb+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-usb+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230920144045.2165758-1-xiaolei.wang@windriver.com>

On 23-09-20 22:40:45, Xiaolei Wang wrote:
> The return type of cdns_set_active () is inconsistent
> depending on whether CONFIG_PM_SLEEP is enabled, so the
> return value is modified to void type.
> 
> Reported-by: Pavel Machek <pavel@denx.de>
> Closes: https://lore.kernel.org/all/ZP7lIKUzD68XA91j@duo.ucw.cz/
> Fixes: 2319b9c87fe2 ("usb: cdns3: Put the cdns set active part outside the spin lock")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> Reviewed-by: Pavel Machek <pavel@denx.de>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>

Acked-by: Peter Chen <peter.chen@kernel.org>
> ---
> 
> Changes in v3:
> - Add Cc: stable@vger.kernel.org
> 
> ---
>  drivers/usb/cdns3/core.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h
> index 4a4dbc2c1561..81a9c9d6be08 100644
> --- a/drivers/usb/cdns3/core.h
> +++ b/drivers/usb/cdns3/core.h
> @@ -131,8 +131,7 @@ void cdns_set_active(struct cdns *cdns, u8 set_active);
>  #else /* CONFIG_PM_SLEEP */
>  static inline int cdns_resume(struct cdns *cdns)
>  { return 0; }
> -static inline int cdns_set_active(struct cdns *cdns, u8 set_active)
> -{ return 0; }
> +static inline void cdns_set_active(struct cdns *cdns, u8 set_active) { }
>  static inline int cdns_suspend(struct cdns *cdns)
>  { return 0; }
>  #endif /* CONFIG_PM_SLEEP */
> -- 
> 2.25.1
> 

-- 

Thanks,
Peter Chen