From: Greg KH <gregkh@linuxfoundation.org>
To: Jia-Ju Bai <baijiaju@buaa.edu.cn>
Cc: hminas@synopsys.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc2: fix possible NULL pointer dereference caused by driver concurrency
Date: Mon, 25 Sep 2023 11:38:38 +0200 [thread overview]
Message-ID: <2023092552-tulip-yo-yo-cbb3@gregkh> (raw)
In-Reply-To: <20230925091741.797863-1-baijiaju@buaa.edu.cn>
On Mon, Sep 25, 2023 at 05:17:41PM +0800, Jia-Ju Bai wrote:
> In _dwc2_hcd_urb_enqueue(), "urb->hcpriv = NULL" is executed without
> holding the lock "hsotg->lock". In _dwc2_hcd_urb_dequeue():
>
> spin_lock_irqsave(&hsotg->lock, flags);
> ...
> if (!urb->hcpriv) {
> dev_dbg(hsotg->dev, "## urb->hcpriv is NULL ##\n");
> goto out;
> }
> rc = dwc2_hcd_urb_dequeue(hsotg, urb->hcpriv); // Use urb->hcpriv
> ...
> out:
> spin_unlock_irqrestore(&hsotg->lock, flags);
>
> When _dwc2_hcd_urb_enqueue() and _dwc2_hcd_urb_dequeue() are
> concurrently executed, the NULL check of "urb->hcpriv" can be executed
> before "urb->hcpriv = NULL". After urb->hcpriv is NULL, it can be used
> in the function call to dwc2_hcd_urb_dequeue(), which can cause a NULL
> pointer dereference.
Odd trailing spaces in your changelog text, is that intentional?
>
> To fix this possible bug, "urb->hcpriv = NULL" should be executed with
> holding the lock "hsotg->lock".
>
> Signed-off-by: Jia-Ju Bai <baijiaju@buaa.edu.cn>
> ---
> drivers/usb/dwc2/hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 657f1f659ffa..35c7a4df8e71 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -4769,8 +4769,8 @@ static int _dwc2_hcd_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
> if (qh_allocated && qh->channel && qh->channel->qh == qh)
> qh->channel->qh = NULL;
> fail2:
> - spin_unlock_irqrestore(&hsotg->lock, flags);
> urb->hcpriv = NULL;
> + spin_unlock_irqrestore(&hsotg->lock, flags);
> kfree(qtd);
> fail1:
> if (qh_allocated) {
> --
> 2.34.1
>
What commit id does this fix?
And how did you test this to verify it works properly?
And how was it found?
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-25 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 9:17 [PATCH] usb: dwc2: fix possible NULL pointer dereference caused by driver concurrency Jia-Ju Bai
2023-09-25 9:38 ` Greg KH [this message]
2023-09-25 10:11 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023092552-tulip-yo-yo-cbb3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=baijiaju@buaa.edu.cn \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox