linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Wentong Wu <wentong.wu@intel.com>,
	arnd@arndb.de, mka@chromium.org, lee@kernel.org, wsa@kernel.org,
	kfting@nuvoton.com, broonie@kernel.org, linus.walleij@linaro.org,
	maz@kernel.org, brgl@bgdev.pl, linux-usb@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-gpio@vger.kernel.org, andriy.shevchenko@linux.intel.com,
	heikki.krogerus@linux.intel.com, andi.shyti@linux.intel.com,
	sakari.ailus@linux.intel.com, bartosz.golaszewski@linaro.org,
	srinivas.pandruvada@intel.com, zhifeng.wang@intel.com
Subject: Re: [PATCH v19 0/4] Add Intel LJCA device driver
Date: Thu, 28 Sep 2023 14:24:13 +0200	[thread overview]
Message-ID: <2023092850-alumni-flanking-77d6@gregkh> (raw)
In-Reply-To: <1e7c1c28-5bbe-49b5-f5ff-8cc84039f34f@redhat.com>

On Thu, Sep 28, 2023 at 02:20:04PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 9/28/23 12:18, Oliver Neukum wrote:
> > On 17.09.23 13:26, Hans de Goede wrote:
> >  
> >> Note I did not ask for a new version to be send right away, but
> >> I'm afraid there has been a bit of miscommunication and instead
> >> of rebasing the next version based on further review Wentong has
> >> send out a new rebased version immediately, sorry about that.
> > 
> > Hi,
> > 
> > what to do now? It's been ten days.
> > I am sure this driver has been very thoroughly reviewed by now.
> > We are dragging this out. Do we want the developer to do another release
> > or do we ask Greg to take it as is?
> > This is becoming almost comical, but that is not what we want driver
> > submission to be.
> > 
> > As far as I am concerned on the USB side everything is fine now.
> > Hans? Greg?
> 
> Note I have been mostly involved in testing these patches I have
> *not* thoroughly reviewed them. I have taken a quick(ish) look
> which did not find anything obviously wrong.
> 
> I agree that at least patch 1/4 is ready for merging. I'm
> not sure if Greg should pick-up the entire series or if
> the rest should be merged through there relevant subsystems
> to also give the relevant subsys maintainer tree.
> 
> For the series:
> 
> Acked-by: Hans de Goede <hdegoede@redhat.com>
> Tested-by: Hans de Goede <hdegoede@redhat.com>

Ok, I'll take a look at these again next week when I return home and
catch up on my pending patch review queue.

thanks for the review!

greg k-h

  reply	other threads:[~2023-09-28 12:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-16 18:53 [PATCH v19 0/4] Add Intel LJCA device driver Wentong Wu
2023-09-16 18:53 ` [PATCH v19 1/4] usb: Add support for Intel LJCA device Wentong Wu
2023-09-28 14:36   ` Greg KH
2023-09-29 11:31     ` Wu, Wentong
2023-10-02 11:30       ` Greg KH
2023-10-03  2:51         ` Wu, Wentong
2023-10-06 13:07           ` Wu, Wentong
2023-09-16 18:53 ` [PATCH v19 2/4] i2c: Add support for Intel LJCA USB I2C driver Wentong Wu
2023-09-29  7:51   ` Wolfram Sang
2023-09-29 16:11     ` Wu, Wentong
2023-09-29 20:10       ` Wolfram Sang
2023-09-16 18:53 ` [PATCH v19 3/4] spi: Add support for Intel LJCA USB SPI driver Wentong Wu
2023-09-16 18:53 ` [PATCH v19 4/4] gpio: update Intel LJCA USB GPIO driver Wentong Wu
2023-09-28 14:17   ` Greg KH
2023-09-29 11:33     ` Wu, Wentong
2023-09-17 10:37 ` [PATCH v19 0/4] Add Intel LJCA device driver Marc Zyngier
2023-09-17 10:42 ` Greg KH
2023-09-17 11:26   ` Hans de Goede
2023-09-28 10:18     ` Oliver Neukum
2023-09-28 12:20       ` Hans de Goede
2023-09-28 12:24         ` Greg KH [this message]
2023-09-28 12:43         ` Mark Brown
2023-09-28 12:28       ` Andi Shyti
2023-09-28 13:56         ` Bartosz Golaszewski
2023-09-18  3:08   ` Wu, Wentong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023092850-alumni-flanking-77d6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=kfting@nuvoton.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mka@chromium.org \
    --cc=oneukum@suse.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=srinivas.pandruvada@intel.com \
    --cc=wentong.wu@intel.com \
    --cc=wsa@kernel.org \
    --cc=zhifeng.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).