From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH v2] usb: fix kernel-doc warning
Date: Mon, 2 Oct 2023 18:26:59 +0000 [thread overview]
Message-ID: <20231002182701.d42xvf3m44o6zqqi@synopsys.com> (raw)
In-Reply-To: <20231002170515.207633-1-swarupkotikalapudi@gmail.com>
On Mon, Oct 02, 2023, Swarup Laxman Kotiaklapudi wrote:
> Fix kernel-doc warnings discovered in usb driver.
>
> Fixes this warning:
> warning: Function parameter or member 'gfladj_refclk_lpm_sel'
> not described in 'dwc3'
>
> Fixes: cf1202418e0b ("usb: fix kernel-doc warning")
This id doesn't match anything in the mainline kernel.
> Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> ---
Please note changes since v1 here.
> drivers/usb/dwc3/core.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index a69ac67d89fe..078edfe0f88e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1106,6 +1106,8 @@ struct dwc3_scratchpad_array {
> * instances in park mode.
> * @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
> * instances in park mode.
> + * @gfladj_refclk_lpm_sel: set if we need to enable reference clock for LPM in
> + * Global Frame Length Adjustment register
> * @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
> * @tx_de_emphasis: Tx de-emphasis value
> * 0 - -6dB de-emphasis
> --
> 2.34.1
>
Also, please prefix $subject line with "usb: dwc3:"
Thanks,
Thinh
prev parent reply other threads:[~2023-10-02 18:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 19:35 [PATCH] usb: fix kernel-doc warning Swarup Laxman Kotiaklapudi
2023-10-02 14:42 ` Greg KH
2023-10-02 15:40 ` swarup
2023-10-02 15:46 ` Greg KH
2023-10-02 17:40 ` swarup
2023-10-02 17:05 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-02 18:26 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002182701.d42xvf3m44o6zqqi@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox