From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD28374F5 for ; Mon, 9 Oct 2023 17:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Fugsy4PG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64DDCC433C8; Mon, 9 Oct 2023 17:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696874044; bh=PPCdcumr+UA++nlG83Y+uutcu7c6YH7gfSHrX1LBEaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fugsy4PGaY/O6EQUhUPCPNBxTT5ZhVVpD2V6xnTzGWIrQ4iQEpPAyKJppVYRXdHws U/czILVQj+Dx99beegFEjvy2b0+qwK5knakS65UN89uuxQEPSwMggMffgFOGJTMqa0 ueQeCCWdqneoBuN2yVeBduVMDdez00ovxrVGlJ4k= Date: Mon, 9 Oct 2023 19:54:01 +0200 From: Greg Kroah-Hartman To: Krishna Kurapati PSSNV Cc: Maciej =?utf-8?Q?=C5=BBenczykowski?= , onathan Corbet , Linyu Yuan , linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com, quic_wcheng@quicinc.com, quic_jackp@quicinc.com Subject: Re: [PATCH 2/2] usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs Message-ID: <2023100910-used-unruly-f750@gregkh> References: <20231009142005.21338-1-quic_kriskura@quicinc.com> <20231009142005.21338-2-quic_kriskura@quicinc.com> <2023100931-reward-justice-ed1c@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 09, 2023 at 09:02:32PM +0530, Krishna Kurapati PSSNV wrote: > > > On 10/9/2023 8:38 PM, Greg Kroah-Hartman wrote: > > On Mon, Oct 09, 2023 at 07:50:05PM +0530, Krishna Kurapati wrote: > > > Currently the NCM driver restricts wMaxSegmentSize that indicates > > > the datagram size coming from network layer to 1514. > > > > I don't see that restriction in the existing driver, where does that > > happen? > > Hi Greg, > > In the ecm_desc, the following line restricts the value: > > .wMaxSegmentSize = cpu_to_le16(ETH_FRAME_LEN), Ok, so is that 1514? I don't know as I don't know what ETH_FRAM_LEN is. So how about saying something to the affect of "the max segment size is currently limited to the ethernet frame length of the kernel which happens to be 1514 at this point in time." thanks, greg k-h